The motivation of method check_ports_exist_on_l3agent in l3_agentscheduler_db.py is to check if there exists one port whose binding host is the same as the input l3 agent, and whose subnet is attached to the input router.
def check_ports_exist_on_l3agent(self, context, l3_agent, router_id):
"""
This function checks for existence of dvr serviceable
ports on the host, running the input l3agent.
"""
subnet_ids = self.get_subnet_ids_on_router(context, router_id)
core_plugin = manager.NeutronManager.get_plugin()
filter = {'fixed_ips': {'subnet_id': subnet_ids}}
ports = core_plugin.get_ports(context, filters=filter)
for port in ports:
if (n_utils.is_dvr_serviced(port['device_owner']) and
l3_agent['host'] == port['binding:host_id']):
return True
return False
But if subnet_ids returned by get_subnet_ids_on_router is empty, get_ports will return all the ports since filter with empty 'subnet_id' is ignored in get_ports.
I think this is not the expected behaviour. With empty subnet_ids, check_ports_exist_on_l3agent can just return False.
Fix proposed to branch: master
Review: https:/