IP filtering can include duplicate instances

[Steven Kaufer]

The IP address filtering logic implemented in the compute API can duplicate instances if a given instance either:
- Has a fixed IP address in more then 1 network that matches the filter
- Has more then 1 fixed IP address in the same network matches the filter

For example:

$ nova list
+-----+-----------------+-------------------------------------------------+
| ID | Name | Networks |
+-----+-----------------+-------------------------------------------------+
| 123 | InstanceTest | gre_shared_1=192.168.0.11; network=194.168.0.14 |
| 456 | InstanceOne | gre_shared_1=192.168.0.3 |
+-----+-----------------+-------------------------------------------------+

$ nova list --ip 19
+-----+-----------------+-------------------------------------------------+
| ID | Name | Networks |
+-----+-----------------+-------------------------------------------------+
| 123 | InstanceTest | gre_shared_1=192.168.0.11; network=194.168.0.14 |
| 123 | InstanceTest | gre_shared_1=192.168.0.11; network=194.168.0.14 |
| 456 | InstanceOne | gre_shared_1=192.168.0.3 |
+-----+-----------------+-------------------------------------------------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/152954

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/152954
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8fc7eee58ebd929dda75e467f93c381091da7ace
Submitter: Jenkins
Branch: master

commit 8fc7eee58ebd929dda75e467f93c381091da7ace
Author: Steven Kaufer <email address hidden>
Date: Tue Feb 3 21:41:05 2015 +0000

    IP filtering can include duplicate instances

    The IP address filtering logic implemented in the compute API can duplicate
    instances if a given instance either:
    - Has a fixed IP address in more then 1 network that matches the filter
    - Has more then 1 fixed IP address in the same network matches the filter

    This patch set prevents the same instance from being added to the list of
    matching instances more than once.

    Change-Id: I07656b005bf7d4eb776430e0efc1da9bbe0e17dd
    Closes-bug: 1417798