EQL driver CI is throwing AttributeErrors

Bug #1417772 reported by Rajini Karthik
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Rajini Karthik

Bug Description

The ssh execute was moved out of the 'With' Block and the CI is now throwing the error below

015-01-29 15:28:31.050 10019 INFO cinder.volume.drivers.eqlx [req-f45b8d0d-99eb-49a1-89cc-193463a7c0ae - - - - -] EQL-driver: executing "cli-settings confirmation off".
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/eventlet/hubs/hub.py", line 457, in fire_timers
    timer()
  File "/usr/local/lib/python2.7/dist-packages/eventlet/hubs/timer.py", line 58, in __call__
    cb(*args, **kw)
  File "/usr/local/lib/python2.7/dist-packages/eventlet/greenthread.py", line 214, in main
    result = function(*args, **kwargs)
  File "/opt/stack/cinder/cinder/volume/drivers/eqlx.py", line 161, in _ssh_execute
    transport = ssh.get_transport()
AttributeError: 'GeneratorContextManager' object has no attribute 'get_transport'

Changed in cinder:
assignee: nobody → Rajini Ram (rajini-ram)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/152705

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/152705
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f5f2ccea52e4d96edb5e9d45fa2398215b5cc732
Submitter: Jenkins
Branch: master

commit f5f2ccea52e4d96edb5e9d45fa2398215b5cc732
Author: rajinir <email address hidden>
Date: Tue Feb 3 15:38:13 2015 -0600

    Fixes the EQL driver CI tests AttributeError

    Moved the ssh object back to a 'with' Block to
    fix the AttributeError thrown by the GeneralContextManager
    in the Eqlx CI tests

    Fixed the unit tests to mock the enter and exit methods
    instead

    Change-Id: I629d20e815fb7da3df90dfeee76abc1c60daeefe
    Closes-Bug: #1417772

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/172988

Thierry Carrez (ttx)
Changed in cinder:
milestone: kilo-2 → 2015.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (stable/juno)

Change abandoned by Mike Perez (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/172988
Reason: Over a month with no update.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.