Deployment fails due to wrong ruby code in Install_ssh_keys

[Alexei Sheplyakov]

2015-02-03 06:20:44 -0800 /Stage[main]/Openstack::Compute/Install_ssh_keys[nova_ssh_key_for_migration] (info): Starting to evaluate the resource
2015-02-03 06:20:44 -0800 /Stage[main]/Openstack::Compute/Install_ssh_keys[nova_ssh_key_for_migration] (err): Could not evaluate: undefined method `grep' for #<String:0x000000067acc80>
/etc/puppet/modules/osnailyfacter/lib/puppet/provider/install_ssh_keys/ssh.rb:31:in `authkey_present?'
/etc/puppet/modules/osnailyfacter/lib/puppet/provider/install_ssh_keys/ssh.rb:9:in `exists?'
/usr/lib/ruby/vendor_ruby/puppet/property/ensure.rb:81:in `retrieve'
/usr/lib/ruby/vendor_ruby/puppet/type.rb:1035:in `retrieve'
/usr/lib/ruby/vendor_ruby/puppet/type.rb:1063:in `retrieve_resource'
/usr/lib/ruby/vendor_ruby/puppet/transaction/resource_harness.rb:223:in `from_resource'
/usr/lib/ruby/vendor_ruby/puppet/transaction/resource_harness.rb:19:in `evaluate'
/usr/lib/ruby/vendor_ruby/puppet/transaction.rb:174:in `apply'
/usr/lib/ruby/vendor_ruby/puppet/transaction.rb:187:in `eval_resource'
/usr/lib/ruby/vendor_ruby/puppet/transaction.rb:117:in `call'
/usr/lib/ruby/vendor_ruby/puppet/transaction.rb:117:in `block (2 levels) in evaluate'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:327:in `block in thinmark'
/usr/lib/ruby/1.9.1/benchmark.rb:295:in `realtime'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:326:in `thinmark'
/usr/lib/ruby/vendor_ruby/puppet/transaction.rb:117:in `block in evaluate'
/usr/lib/ruby/vendor_ruby/puppet/graph/relationship_graph.rb:118:in `traverse'
/usr/lib/ruby/vendor_ruby/puppet/transaction.rb:108:in `evaluate'
/usr/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:164:in `block in apply'
/usr/lib/ruby/vendor_ruby/puppet/util/log.rb:149:in `with_destination'
/usr/lib/ruby/vendor_ruby/puppet/transaction/report.rb:108:in `as_logging_destination'
/usr/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:163:in `apply'
/usr/lib/ruby/vendor_ruby/puppet/configurer.rb:125:in `block in apply_catalog'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:161:in `block in benchmark'
/usr/lib/ruby/1.9.1/benchmark.rb:295:in `realtime'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:160:in `benchmark'
/usr/lib/ruby/vendor_ruby/puppet/configurer.rb:124:in `apply_catalog'
/usr/lib/ruby/vendor_ruby/puppet/configurer.rb:192:in `run'
/usr/lib/ruby/vendor_ruby/puppet/application/apply.rb:268:in `apply_catalog'
/usr/lib/ruby/vendor_ruby/puppet/application/apply.rb:218:in `main'
/usr/lib/ruby/vendor_ruby/puppet/application/apply.rb:146:in `run_command'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:364:in `block (2 levels) in run'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:470:in `plugin_hook'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:364:in `block in run'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:478:in `exit_on_fail'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:364:in `run'
/usr/lib/ruby/vendor_ruby/puppet/util/command_line.rb:137:in `run'
/usr/lib/ruby/vendor_ruby/puppet/util/command_line.rb:91:in `execute'
/usr/bin/puppet:4:in `<main>'
2015-02-03 06:20:44 -0800 /Stage[main]/Openstack::Compute/Install_ssh_keys[nova_ssh_key_for_migration] (info): Evaluated in 0.00 seconds

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/152636

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/152636
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=3b471190eaabe433c98c63fafe46f747d3e9268f
Submitter: Jenkins
Branch: master

commit 3b471190eaabe433c98c63fafe46f747d3e9268f
Author: Alexei Sheplyakov <email address hidden>
Date: Tue Feb 3 19:45:58 2015 +0300

    Fix install_ssh_key provider so it works with ruby >= 1.9

    There's no String.grep in ruby >= 1.9, rewrite the code so it works both
    with the old (1.8) and the newer versions of ruby (>= 1.9)

    blueprint support-ubuntu-trusty
    Closes-Bug: #1417676

    Change-Id: I92fe01fceaa851bb03a5dbc72e48550a95343aa2

[Kyrylo Romanenko (kromanenko)]

Deployed current MOS 6.1 build,
{"build_id": "2015-02-23_22-54-44", "ostf_sha": "1a0b2c6618fac098473c2ed5a9af11d3a886a3bb", "build_number": "140", "release_versions": {"2014.2-6.1": {"VERSION": {"build_id": "2015-02-23_22-54-44", "ostf_sha": "1a0b2c6618fac098473c2ed5a9af11d3a886a3bb", "build_number": "140", "api": "1.0", "nailgun_sha": "3616ae9df4ac3e088157bb94f73743a521f76f1a", "production": "docker", "python-fuelclient_sha": "5657dbf06fddb74adb61e9668eb579a1c57d8af8", "astute_sha": "d81ff53c2f467151ecde120d3a4d284e3b5b3dfc", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "b975019fabdb429c1869047df18dd792d2163ecc", "fuellib_sha": "8b79d47ef41bff293210d2a7b1bb02843f70948d"}}}, "auth_required": true, "api": "1.0", "nailgun_sha": "3616ae9df4ac3e088157bb94f73743a521f76f1a", "production": "docker", "python-fuelclient_sha": "5657dbf06fddb74adb61e9668eb579a1c57d8af8", "astute_sha": "d81ff53c2f467151ecde120d3a4d284e3b5b3dfc", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "b975019fabdb429c1869047df18dd792d2163ecc", "fuellib_sha": "8b79d47ef41bff293210d2a7b1bb02843f70948d"}

Bug was reproduced for configurations with Ceph. Now it is fixed.