apt-proxy can be incorrectly set when the fallback from http-proxy is used

[Michael Foord]

Proxy configuration for the deployed environment is done with the http-proxy, https-proxy and apt-proxy settings in environments.yaml. If http-proxy is set but apt-proxy isn't then apt-proxy falls back to http-proxy as a default (as they're usually the same).

http-proxy (which ends up as an environment variable) can be in the form <ip-addr>:port, however apt-proxy must be in the form http://<ip-addr>:port/ - so a valid http-proxy setting can end up as an invalid apt-proxy setting. If http-proxy is not in the correct form for apt-proxy we should correctly format it when we use it as a fallback.

The code that does this (Config.AptProxySettings) is line 854 in environs/config/config.go

In addition, once the apt config file has been written re-provisioning a machine (e.g. for manual provider) won't result in a *new* apt config file being written out. So an incorrect setting remains even once corrected. This is probably an issue in the proxyupdateworker that writes out the system files.

[James Tunnicliffe (dooferlad)]

Have got a fix for the initial problem (http:// missing causes problems) but it makes lots of tests fail that expect the scheme part of URLs to be missing. Just need to update the tests, so more tedious than difficult.

Haven't looked into the proxyupdateworker part. Could you give me some reproducer instructions?

[Michael Foord (mfoord)]

To reproduce create a kvm image (or similar) with http-proxy and https-proxy set for the manual provider in environments.yaml. Use the incorrect format (or simply incorrect proxy settings).

Then bootstrap the manual provider. Then destroy-environment and correct the settings in environments.yaml. When you re-provision again the apt config file written by juju should be unchanged (or rather should have changed to reflect the new values - the bug is that it isn't changed).