pt-stalk with --collect-strace output doesn't go to an YYYY_MM_DD_HH_mm_ss-strace file
Bug #1417558 reported by
Daniel Guzmán Burgos
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Frank Cizmich | ||
Bug Description
pt-stalk when used along with --collect-strace doesn't write the strace output to the expected destination file, and by inspecting the code looks like is because 2 reasons:
$CMD_STRACE -T -s 0 -f -p $mysqld_pid > "${DEST}/$d-strace" &
The ${DEST} variable is not defined. And the strace output is written to the stderr, not the stdout. Also, destination file should be "$d/$p-strace"
A fix for this could be to pass the destination file as a -o param:
$CMD_STRACE -T -s 0 -f -p $mysqld_pid -o "$d/$p-strace" &
Which it works.
Tested on pt-stalk v. 2.2.13
Related branches
lp:~percona-toolkit-dev/percona-toolkit/pt-stalk-with--collect-strace-output-doesnt-go-to-an-YYYY_MM_DD_HH_mm_ss-strace-file-1417558
- Percona Toolkit developers: Pending requested
-
Diff: 11 lines (+1/-1)1 file modifiedbin/pt-stalk (+1/-1)
Revision history for this message
| Frank Cizmich (frank-cizmich) wrote | #1 |
| Changed in percona-toolkit: | |
| assignee: | nobody → Frank Cizmich (frank-cizmich) |
| importance: | Undecided → Medium |
| milestone: | none → 2.2.14 |
| status: | New → In Progress |
| Changed in percona-toolkit: | |
| status: | In Progress → Fix Committed |
| Changed in percona-toolkit: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #2 |
To post a comment you must log in.
Confirmed, fixed and tested using Daniel Guzman's suggestion.