swap_volume calls DriverBlockDevice save with wrong parameters

Bug #1417348 reported by melanie witt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
melanie witt

Bug Description

Commit https://review.openstack.org/#/c/148788/ removed the context
parameter from the DriverBlockDevice wrapper save function. One call
of the function was missed in the driver, swap_volume is calling save with a context.

Tags: libvirt
melanie witt (melwitt)
description: updated
Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/152356
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=494756c822793f28d69c36e23920ff59809e9a44
Submitter: Jenkins
Branch: master

commit 494756c822793f28d69c36e23920ff59809e9a44
Author: melanie witt <email address hidden>
Date: Tue Feb 3 00:42:56 2015 +0000

    fix call of DriverVolumeBlockDevice save in swap_volume

    Commit fac0e90b3d54e9a2c74f8017b9a9c592bc296e0c removed the context
    parameter from the DriverBlockDevice wrapper save function. One call
    of the function was missed in the driver and this change fixes the
    call and enhances the unit test to verify the save function call
    parameters.

    Closes-Bug: #1417348

    Change-Id: I7f5c5580e3a0345c0c40b4b2d66bc99b1451c883

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.