occasional failure of functional test_update_instance_error_causes_group_error

[Angus Salkeld]

http://logs.openstack.org/66/150366/4/check/check-heat-dsvm-functional-mysql/21d6bb5/console.html#_2015-02-02_10_48_30_587

2015-02-02 10:48:30.592 | 2015-02-02 10:48:30.585 | Traceback (most recent call last):
2015-02-02 10:48:30.622 | 2015-02-02 10:48:30.587 | File "heat_integrationtests/functional/test_instance_group.py", line 289, in test_update_instance_error_causes_group_error
2015-02-02 10:48:30.622 | 2015-02-02 10:48:30.589 | self._assert_instance_state(nested_ident, 0, 3)
2015-02-02 10:48:30.622 | 2015-02-02 10:48:30.591 | File "heat_integrationtests/functional/test_instance_group.py", line 131, in _assert_instance_state
2015-02-02 10:48:30.622 | 2015-02-02 10:48:30.593 | self.assertEqual(0, num_failed)
2015-02-02 10:48:30.623 | 2015-02-02 10:48:30.595 | File "/opt/stack/new/heat/.tox/integration/local/lib/python2.7/site-packages/testtools/testcase.py", line 348, in assertEqual
2015-02-02 10:48:30.623 | 2015-02-02 10:48:30.597 | self.assertThat(observed, matcher, message)
2015-02-02 10:48:30.623 | 2015-02-02 10:48:30.599 | File "/opt/stack/new/heat/.tox/integration/local/lib/python2.7/site-packages/testtools/testcase.py", line 433, in assertThat
2015-02-02 10:48:30.623 | 2015-02-02 10:48:30.601 | raise mismatch_error
2015-02-02 10:48:30.623 | 2015-02-02 10:48:30.603 | MismatchError: 0 != 1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/152094

[Angus Salkeld (asalkeld)]

I think this is because we are just not waiting for the update to happen, so we still have a failed resource in the stack.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/152094
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=78da88dd77fa11fade502a5b083866c3cf48d30a
Submitter: Jenkins
Branch: master

commit 78da88dd77fa11fade502a5b083866c3cf48d30a
Author: Angus Salkeld <email address hidden>
Date: Tue Feb 3 11:27:40 2015 +1000

    Wait for all resources to get updated before asserting state

    Change-Id: Ieec2c9d540c30c3e4da5b38026daf60de286b2ff
    Closes-bug: 1417077