No disable reason defined for new services when "enable_new_services=False"

Bug #1417027 reported by Belmiro Moreira
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Belmiro Moreira

Bug Description

When a service is added and "enable_new_services=False" there is no disable
reason specified.
Services can be disabled by several reasons and the admins can use the API to
specify a reason. However, having services disabled with no reason specified
creates additional checks on the operators side that increases with the
deployment size.

Revision history for this message
Sylvain Bauza (sylvain-bauza) wrote :

I agree with the reporter, we should at least provide some way to differenciate why a service is disabled, especially when it's automatically disabled using the opt above

Changed in nova:
importance: Undecided → Wishlist
status: New → Triaged
tags: added: compute low-hanging-fruit
Changed in nova:
assignee: nobody → Belmiro Moreira (moreira-belmiro-email-lists)
Changed in nova:
status: Triaged → In Progress
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

Please switch this back to "In Progress" when there are active reviews.

Changed in nova:
status: In Progress → Confirmed
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

Ah, looks like there is a review in progress - https://review.openstack.org/#/c/136645/

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/136645
Reason: This patch as been WIP'ed for a very long time, so I am going to abandon it to keep the review queue sane. Please restore the change when its ready for review.

Changed in nova:
assignee: Belmiro Moreira (moreira-belmiro-email-lists) → nobody
status: In Progress → Confirmed
Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote :

This sounds like a real bug and not a like a change request, that's why I switch the importance from "wishlist" to "low". If you are interested in picking this up, you can cherry-pick [1] and re-push it.

[1] https://review.openstack.org/#/c/136645/

Changed in nova:
importance: Wishlist → Low
Changed in nova:
assignee: nobody → Belmiro Moreira (moreira-belmiro-email-lists)
Revision history for this message
Sujitha (sujitha-neti) wrote :

Belmiro Moreira: Please change the status to InProgress if you are currently working on it.

Revision history for this message
Belmiro Moreira (moreira-belmiro-email-lists) wrote :

Sujitha, thanks for pointing out.

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/319461

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/319461
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4eb95a1b897505fb4e4ec17541eeebb79e7217a8
Submitter: Jenkins
Branch: master

commit 4eb95a1b897505fb4e4ec17541eeebb79e7217a8
Author: Belmiro Moreira <email address hidden>
Date: Fri May 20 23:14:03 2016 +0200

    No disable reason defined for new services

    Services can be disabled by several reasons and admins can use the API to
    specify a reason. However, currently if new services are added and
    "enable_new_services=False" there is no disable reason specified.
    Having services disabled with no reason specified creates additional checks on
    the operators side that increases with the deployment size.

    This patch specifies the disable reason:
    "New service disabled due to config option"
    when a new service is added and "enable_new_services=False".

    Closes-Bug: #1417027

    Change-Id: I52dd763cf1b58ba3ff56fe97f37eca18c915681d

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/nova 14.0.0.0b2

This issue was fixed in the openstack/nova 14.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.