Typo in nova/virt/disk/vfs/localfs.py

Bug #1416970 reported by Takashi Natsume
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Takashi Natsume

Bug Description

In 'setup' method of 'VFSLocalFS' class(nova/virt/disk/vfs/localfs.py),
there is an extra parenthesis in log message.
It should be removed.
And it had better to put ':' between 'Failed to mount image' and an exception string.

--------------------------------------------------------------------------------
2015-01-30 21:30:00,000.428 15504 DEBUG nova.virt.disk.vfs.localfs [-] Failed to mount image Failed to mount filesystem: Unexpected error while running command.
Command: sudo nova-rootwrap /etc/nova/rootwrap.conf mount /dev/nbd1 /tmp/openstack-vfs-localfso10pWg
Exit code: 32
Stdout: u''
Stderr: u'mount: you must specify the filesystem type\n') setup /usr/lib/python2.7/dist-packages/nova/virt/disk/vfs/localfs.py:80
--------------------------------------------------------------------------------

Changed in nova:
assignee: nobody → Takashi NATSUME (natsume-takashi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/152005

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/152005
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7cb773e2474f5d3f0672ea6c665202bd72982f9a
Submitter: Jenkins
Branch: master

commit 7cb773e2474f5d3f0672ea6c665202bd72982f9a
Author: Takashi NATSUME <email address hidden>
Date: Mon Feb 2 16:05:05 2015 +0900

    Fix typo in nova/virt/disk/vfs/localfs.py

    Fix log message typo in 'setup' method of 'VFSLocalFS' class.

    Change-Id: Id1e369e4546c093edc8a94f49f00842ad65607cc
    Closes-Bug: 1416970

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.