aws nested stack does not show failures in resources when adopting

Bug #1416934 reported by Angus Salkeld
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Angus Salkeld

Bug Description

If you do an adopt on a stack with a aws nested stack in it and something fails in that nested stack, you will not get
the failure. This is because NestedStack does not have a check_adopt_complete().

Angus Salkeld (asalkeld)
Changed in heat:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Angus Salkeld (asalkeld)
Angus Salkeld (asalkeld)
Changed in heat:
milestone: none → kilo-2
tags: added: abandon-adopt
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/152072

Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/152072
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=6b520b2cd19bd223f9c15b38ef422f5515cf63f8
Submitter: Jenkins
Branch: master

commit 6b520b2cd19bd223f9c15b38ef422f5515cf63f8
Author: Angus Salkeld <email address hidden>
Date: Mon Feb 2 13:17:15 2015 +1000

    Add check_adopt_complete to the stack_resource

    NestedStack was hiding adopt failures from the user.
    We have identical versions of check_adopt_complete in
    template_resource and resource_group, so just move it
    to the base class to catch all the nested stack implementations.

    Change-Id: I07f3943b56fb925e550246b41df2956655869301
    Closes-bug: 1416934

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.