event_type for role assignment notifications is incorrect

[Steve Martinelli]

the event_type for role_notification events is currently set as:

  identity.created.role_assignment (or on a delete operation, identity.deleted.role_assignment)

To keep in sync with other openstack projects, it should be:

  identity.role_assignment.created (or on a delete operation, identity.role_assignment.deleted)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/151551
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=2f90965e018f91563896502f6dd8c9953e80fbe9
Submitter: Jenkins
Branch: master

commit 2f90965e018f91563896502f6dd8c9953e80fbe9
Author: Steve Martinelli <email address hidden>
Date: Fri Jan 30 01:34:55 2015 -0500

    Refactor _send_audit_notification

    In preparation of the CADF everywhere work, we should refactor
    _send_audit_notification to not make assumptions about target
    and event_type.

    partially implements bp: cadf-everywhere
    Closes-Bug: #1416767

    Change-Id: I20036056f8b95854f35cb46e716f4b11c6418520

[Steve Martinelli (stevemar)]

this was actually not fixed, the "closes-bug" portion should have been removed from the commit message, sorry.

[Steve Martinelli (stevemar)]

@lin, i put up something for this: https://review.openstack.org/#/c/167501/ but wasn't sure if i liked the approach, feel free to use that patch or create another.

[Lin Hua Cheng (lin-hua-cheng)]

@Steve: I went through the patch when you tried to fix the name before, the suggestion was to send both event_type (old and new), and document that the old name is getting deprecated.

I think that makes sense, in case the deployer already have some actions triggered by that event_type we don't want to break that.

[Steve Martinelli (stevemar)]

review is up: https://review.openstack.org/#/c/167501/

[David Stanek (dstanek)]

Has there been any discussion about how this will impact people that are using the notifications? For some time they will be getting two for the same event and have a time where they have to change their tooling to look for the new message. Maybe a link to the thread or something?

[Steve Martinelli (stevemar)]

@dstanek, it would depend on what the user is using to listen to the events.

for example, if using ceilometer, then this is based on event_definitions.yaml, and the user would ignore the new/correct event: https://github.com/openstack/ceilometer/blob/master/etc/ceilometer/event_definitions.yaml#L154-L165 and just listen for the old one.

[Steve Martinelli (stevemar)]

@dstanek, we will include this in the release/upgrade notes

[David Stanek (dstanek)]

The DocImpact is great, thanks.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167501
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=8695b1adf7cd7638699c5efc742c2959534b5257
Submitter: Jenkins
Branch: master

commit 8695b1adf7cd7638699c5efc742c2959534b5257
Author: Steve Martinelli <email address hidden>
Date: Wed Mar 25 02:18:27 2015 -0400

    Rename notification for create/delete grants

    For backward compatiblity, old and new format of event
    type will still be sent. The old format is marked as
    deprecated and to be removed in the next release.

    Co-Authored-By: Lin Hua Cheng <email address hidden>
    DocImpact
    Change-Id: Ic19e8e6983e63789b42d8fb9677ffd115a40fc9e
    Closes-Bug: #1416767