vmware unit tests are still skipped in openstack/neutron

Bug #1416593 reported by Salvatore Orlando
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Salvatore Orlando

Bug Description

Despite having fixed the problem that caused the skip during the adv services spin off, the vmware unit tests are still skipped because the __init__.py file is missing (they're just not a test package for testr)

This has recently caused a regression which has been correctly caught in the repository where the "decomposed" plugin is being prepped up. Until the decomposition is complete however, it might be worth ensuring unit tests are executed as part of the py27 job on openstack/neutron

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/151928

Changed in neutron:
status: New → In Progress
Kyle Mestery (mestery)
Changed in neutron:
milestone: kilo-2 → kilo-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/151928
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=568f3562ae540a2eb5d6784d43f92786084d34f6
Submitter: Jenkins
Branch: master

commit 568f3562ae540a2eb5d6784d43f92786084d34f6
Author: Salvatore Orlando <email address hidden>
Date: Sat Jan 31 23:49:38 2015 -0800

    Restore and fix vmware unit tests

    This patch actually restores vmware unit tests, by adding back
    the __init__.py file which was renamed during the advanced
    service spinoff and not reinstated when fixing vmware code to
    comply with the spinoff.

    Furthermore, this patch also fixes a minor issue with context
    usage in vmware unit tests which is triggering failures because
    of the new database constraint introduced with the commit
    79c97120de9cff4d0992b5d41ff4bbf05e890f89

    Finally, flake8 tests on vmware directories are also restored
    with this patch.

    Change-Id: Ib63463fca28bbb4a1eb60b8f5f4b63b3d3367c9e
    Closes-Bug: #1416593
    Closes-Bug: #1416596

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.