Policy check is missing outer parens

Bug #1416583 reported by Dan Nguyen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Dan Nguyen

Bug Description

The policy check call seems to be missing another set of parens and a comma resulting in incorrect parsing of the action in the policy.py

https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/keystone.py#L147

....
 user = request.user
    if admin:
        if not policy.check(("identity", "admin_required"), request):
            raise exceptions.NotAuthorized
        endpoint_type = 'adminURL'
....

Changed in horizon:
assignee: nobody → Dan Nguyen (daniel-a-nguyen)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/151832

Changed in horizon:
status: New → In Progress
Changed in horizon:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/151832
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=771152849ade8793b6022920003b9f30f53d762c
Submitter: Jenkins
Branch: master

commit 771152849ade8793b6022920003b9f30f53d762c
Author: daniel-a-nguyen <email address hidden>
Date: Fri Jan 30 16:58:56 2015 -0800

    Correct the policy check call in keystone

    Change-Id: Ie72ea40b998352fbc9bb268d9e87b795288415e9
    Closes-Bug: #1416583

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.