Fix neutron-fwaas unit test failure due to mutiple issues.

Bug #1416522 reported by Trinath Somanchi
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Trinath Somanchi

Bug Description

Due to recent updates to neutron/agents/l3/router_info.py, neutron-fwaas unit tests are failing with the following error.

ft1.59: neutron_fwaas.tests.unit.services.firewall.agents.l3reference.test_firewall_l3_agent.TestFwaasL3AgentRpcCallback.test_get_router_info_list_for_tenant_for_namespaces_disabled_StringException: Traceback (most recent call last):
_StringException: Empty attachments:
  pythonlogging:''
  pythonlogging:'neutron.api.extensions'
  stderr
  stdout

Traceback (most recent call last):
  File "neutron_fwaas/tests/unit/services/firewall/agents/l3reference/test_firewall_l3_agent.py", line 371, in test_get_router_info_list_for_tenant_for_namespaces_disabled
    self._get_router_info_list_helper(use_namespaces=False)
  File "neutron_fwaas/tests/unit/services/firewall/agents/l3reference/test_firewall_l3_agent.py", line 355, in _get_router_info_list_helper
    ri = self._prepare_router_data()
  File "neutron_fwaas/tests/unit/services/firewall/agents/l3reference/test_firewall_l3_agent.py", line 351, in _prepare_router_data
    router=router, ns_name=ns)
TypeError: __init__() got multiple values for keyword argument 'router'

Traceback (most recent call last):
_StringException: Empty attachments:
  pythonlogging:''
  pythonlogging:'neutron.api.extensions'
  stderr
  stdout

Traceback (most recent call last):
  File "neutron_fwaas/tests/unit/services/firewall/agents/l3reference/test_firewall_l3_agent.py", line 371, in test_get_router_info_list_for_tenant_for_namespaces_disabled
    self._get_router_info_list_helper(use_namespaces=False)
  File "neutron_fwaas/tests/unit/services/firewall/agents/l3reference/test_firewall_l3_agent.py", line 355, in _get_router_info_list_helper
    ri = self._prepare_router_data()
  File "neutron_fwaas/tests/unit/services/firewall/agents/l3reference/test_firewall_l3_agent.py", line 351, in _prepare_router_data
    router=router, ns_name=ns)
TypeError: __init__() got multiple values for keyword argument 'router'

Also, there are issues with test_varmour_router.py and test_varmour_fwaas.py related to AGENT CONFIG options.

ft1.56: neutron_fwaas.tests.unit.services.firewall.drivers.varmour.test_varmour_fwaas.TestBasicRouterOperations.test_firewall_with_rules_StringException: Traceback (most recent call last):
_StringException: Empty attachments:
  pythonlogging:''
  pythonlogging:'neutron.api.extensions'
  stderr
  stdout

Traceback (most recent call last):
  File "neutron_fwaas/tests/unit/services/firewall/drivers/varmour/test_varmour_fwaas.py", line 209, in test_firewall_with_rules
    router = self._create_router()
  File "neutron_fwaas/tests/unit/services/firewall/drivers/varmour/test_varmour_fwaas.py", line 88, in _create_router
    router = varmour_router.vArmourL3NATAgent(HOSTNAME, self.conf)
  File "neutron_fwaas/services/firewall/agents/varmour/varmour_router.py", line 54, in __init__
    super(vArmourL3NATAgent, self).__init__(host, conf)
  File "/home/jenkins/workspace/gate-neutron-fwaas-python27/.tox/py27/src/neutron/neutron/agent/l3/agent.py", line 155, in __init__
    resource_type='router')
  File "/home/jenkins/workspace/gate-neutron-fwaas-python27/.tox/py27/src/neutron/neutron/agent/linux/external_process.py", line 150, in __init__
    if self._config.AGENT.check_child_processes_interval:
  File "/home/jenkins/workspace/gate-neutron-fwaas-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_config/cfg.py", line 2384, in __getattr__
    return self._conf._get(name, self._group)
  File "/home/jenkins/workspace/gate-neutron-fwaas-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_config/cfg.py", line 2116, in _get
    value = self._do_get(name, group, namespace)
  File "/home/jenkins/workspace/gate-neutron-fwaas-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_config/cfg.py", line 2134, in _do_get
    info = self._get_opt_info(name, group)
  File "/home/jenkins/workspace/gate-neutron-fwaas-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_config/cfg.py", line 2262, in _get_opt_info
    raise NoSuchOptError(opt_name, group)
NoSuchOptError: no such option in group AGENT: check_child_processes_interval

Changed in neutron:
assignee: nobody → Trinath Somanchi (trinath-somanchi)
status: New → In Progress
summary: - Fix neutron-fwaas unit test failure due to router_info.RouterInfo().
+ Fix neutron-fwaas unit test failure due to mutiple issues.
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-fwaas (master)

Reviewed: https://review.openstack.org/151734
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=f4bb327e3163e25d3911019259b7745a365d6933
Submitter: Jenkins
Branch: master

commit f4bb327e3163e25d3911019259b7745a365d6933
Author: Trinath Somanchi <email address hidden>
Date: Sat Jan 31 00:41:21 2015 +0530

    Fix neutron-fwaas unit test failures due to multiple issues

    neutron-fwaas unit tests are failing due the following issues:

    [1] init parameters of router_info.RouterInfo.
    [2] 'register_process_monitor_opts' in varmour router and fwaas UT.

    This patch fixes those issues.

    Closes-Bug: #1416522

    Change-Id: I70a4b47777ea41a8070253cf17e667cb9fec0dea

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.