ilo driver tests doesn't use proliantutils module if available in virtual environment

Bug #1416421 reported by Ramakrishnan G (rameshg87)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Ramakrishnan G (rameshg87)

Bug Description

Currently all the tests in ironic/tests/drivers/ilo mock the ilo client completely and doesn't use the proliantutils module if available in the virtual environment. This needs to be fixed.

Tags: ilo
tags: added: driver
Changed in ironic:
assignee: nobody → Ramakrishnan G (rameshg87)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/151674

Changed in ironic:
status: New → In Progress
Dmitry Tantsur (divius)
tags: added: ilo
removed: driver
Changed in ironic:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/151674
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=c6f44319946c46bccf1ec030694290e1a449bed8
Submitter: Jenkins
Branch: master

commit c6f44319946c46bccf1ec030694290e1a449bed8
Author: Ramakrishnan G <email address hidden>
Date: Fri Jan 30 15:29:54 2015 +0000

    Use prolianutils module for ilo driver tests

    This change adds all components on proliantutils module
    to third_party_driver_mocks. This enables the ilo driver
    tests to use the proliantutils module when it is available, and
    use the mocks when proliantutils module is not available. This
    commit modifies all the ilo driver tests to use the imported
    proliantutils module (rather than mocking it completely).

    Change-Id: Ief88b194374585c7cfc3c3804b4ea04620fe21e7
    Closes-bug: 1416421

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.