oslo.policy

need to evaluate some of the public symbols to see if they should be private

Bug #1415633 reported by Doug Hellmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.policy
Fix Released
High
Ian Cordasco
oslo.policy 0.1.0

Bug Description

The Rules class looks like it could be made private.

Some of the file parsing code could probably be made private, and moved to its own module.

Tags: prerelease
Doug Hellmann (doug-hellmann)
Changed in oslo.policy:
milestone: none → next-kilo
Doug Hellmann (doug-hellmann)
tags: added: prerelease
Revision history for this message
Steve Martinelli (stevemar) wrote :

Looks like Keystone uses both Enforcer: https://github.com/openstack/keystone/blob/c4c8d0b99a0404f4dcdb2f87c48fe15ee1526197/keystone/policy/backends/rules.py#L55

and Rules: https://github.com/openstack/keystone/blob/c4c8d0b99a0404f4dcdb2f87c48fe15ee1526197/keystone/policy/backends/rules.py#L64-L65

Revision history for this message
Steve Martinelli (stevemar) wrote :

Maybe we can privatize ParseStateMeta and ParseState ?

Revision history for this message
Ian Cordasco (icordasc) wrote :

Those sound like a good things to privatize Steve.

Revision history for this message
Steve Martinelli (stevemar) wrote :

Addressed by:

- https://review.openstack.org/#/c/153149/
- https://review.openstack.org/#/c/153310/

Changed in oslo.policy:
assignee: nobody → Ian Cordasco (icordasc)
status: Triaged → In Progress
Revision history for this message
Steve Martinelli (stevemar) wrote :

All of the above patches have merged, marking this as committed.

Changed in oslo.policy:
status: In Progress → Fix Committed
Doug Hellmann (doug-hellmann)
Changed in oslo.policy:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.