EQLX Driver: Refactor ssh code to common utils

Bug #1415186 reported by Rajini Karthik
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Invalid
Undecided
Rajini Karthik

Bug Description

Equallogic driver has some code that can be moved to utils.

There is a very similar implementation of _run_ssh() in SanDriver: https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/san/san.py#L104
I think, this function should be taken out and made available probably in processutils. so that it can be used by other drivers.

tags: added: drivers
Changed in cinder:
assignee: nobody → Rajini Ram (rajini-ram)
tags: added: backport for proposed
removed: drivers
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/203720

Changed in cinder:
status: New → In Progress
Eric Harney (eharney)
tags: removed: backport for proposed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Rajini Ram (<email address hidden>) on branch: master
Review: https://review.openstack.org/203720
Reason: he common processutils doesn't seem to work for equalogic cli. Have to stick back to paramiko custom implementation.
Abandoningg this review. Will submit a separate review for just deprecating eqlx_cli_timeout in favor of ssh_conn_timeout

Revision history for this message
Rajini Karthik (rajini-karthik) wrote :

This bug should be closed

Changed in cinder:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.