neutron-plugin-ovs-service not restarted on config changes

[Matt Fischer]

I was changing some rabbitmq config portions of neutron, specifically which server to talk to (switch to LB). Everything worked (heat, cinder, etc) except for neutron-openvswitch-agent, whcih did not restart to point at the LB. I confirmed this by looking at how long it had been running and comparing the connections to rabbit with the local box using netstat and lsof.

As far as I can tell there is a collector that should be catching all this, but it's not.

  if $enabled {
    Neutron_config<||> ~> Service['neutron-plugin-ovs-service']
  }

To contrive another example, I bumped the value of neutron::server::database_max_overflow from 20 to 21. Here is what restarted:

Notice: /Stage[main]/Neutron::Server/Neutron_config[database/max_overflow]/value: value changed '20' to '21'
Info: /Stage[main]/Neutron::Server/Neutron_config[database/max_overflow]: Scheduling refresh of Service[neutron-server]
Info: /Stage[main]/Neutron::Server/Neutron_config[database/max_overflow]: Scheduling refresh of Service[neutron-metadata]
Info: /Stage[main]/Neutron::Server/Neutron_config[database/max_overflow]: Scheduling refresh of Service[neutron-l3]
Info: /Stage[main]/Neutron::Server/Neutron_config[database/max_overflow]: Scheduling refresh of Service[neutron-dhcp-service]
...

Notice: /Stage[main]/Neutron::Agents::Dhcp/Service[neutron-dhcp-service]: Triggered 'refresh' from 1 events
Notice: /Stage[main]/Neutron::Agents::L3/Service[neutron-l3]: Triggered 'refresh' from 1 events
Notice: /Stage[main]/Neutron::Agents::Metadata/Service[neutron-metadata]: Triggered 'refresh' from 1 events
Notice: /Stage[main]/Neutron::Server/Service[neutron-server]: Triggered 'refresh' from 1 events

Something is amiss here and I'm not sure what.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/151534

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/151534
Committed: https://git.openstack.org/cgit/stackforge/puppet-neutron/commit/?id=e8c1426440de98e7ddac9b52e9aac60a7cc0ca1c
Submitter: Jenkins
Branch: master

commit e8c1426440de98e7ddac9b52e9aac60a7cc0ca1c
Author: Matt Fischer <email address hidden>
Date: Thu Jan 29 21:40:17 2015 -0700

    Notify the ovs-agent service if the config changes

    Change-Id: Ic3debdde0b2f848000f1037be6b8314d694c0eaf
    Closes-Bug: #1415185