Default Route not added for IPv6 subnets in HA Router

[Sridhar Gaddam]

In an HA setup, keepalived would configure the default gateway (in the master HA router) by parsing the "virtual_routes" section of keepalived.conf file. In the current Neutron code, virtual_routes section is constructed keeping in view of IPv4 subnets.
This has to be suitably enhanced to support IPv6 subnets.

[Assaf Muller (amuller)]

Is this the problematic code?
https://github.com/openstack/neutron/blob/master/neutron/agent/linux/keepalived.py#L103

Could you please expand on the issue?

[Sridhar Gaddam (sridhargaddam)]

@Assaf, changes are required in the following section of code... https://github.com/openstack/neutron/blob/master/neutron/agent/l3/ha.py#L168

For IPv4, as you know, we are constructing the virtual_routes section as follows.
    virtual_routes {
        0.0.0.0/0 via 20.1.1.1 dev qg-8a657f2e-46
    }

When the same is applied for an IPv6 subnet, it is added as shown below.
This needs some minor change (i.e., 0::/0) for IPv6 subnets.

However, for an IPv6 subnet the same is constructed as follows.
    virtual_routes {
        0.0.0.0/0 via 2014::1 dev qg-8a657f2e-46
    }

Along with this change, we also need keepalived 1.2.8 (or above) for the default route to be added.
I'll propose a separate patch for Keepalived requirement.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/150787

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/150787
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a1318ae187f1695e2e49bbde32eb75230e96aefe
Submitter: Jenkins
Branch: master

commit a1318ae187f1695e2e49bbde32eb75230e96aefe
Author: sridhargaddam <email address hidden>
Date: Wed Jan 28 14:18:00 2015 +0000

    Default route missing for IPv6 subnets in HA Router

    In an HA setup, keepalived would configure the default gateway (in the master
    HA router) by parsing the "virtual_routes" section of keepalived.conf file.
    The "virtual_routes" section is properly constructed for an IPv4 subnet, but
    requires a minor change for IPv6 subnets.

    Closes-Bug: #1414937
    Change-Id: I54070e048577292d98d86fcc9ca8b9d3e72b4ebe

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/159000

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/161325

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sridhar Gaddam (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/159000
Reason: Abandoned in favor of following patch - https://review.openstack.org/#/c/161325/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/161325
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5cb7a20804e4259e4c06716a1743ba7fbaf68740
Submitter: Jenkins
Branch: stable/juno

commit 5cb7a20804e4259e4c06716a1743ba7fbaf68740
Author: sridhargaddam <email address hidden>
Date: Wed Feb 25 05:42:47 2015 +0000

    Default route missing for IPv6 subnets in HA Router

    In an HA setup, keepalived would configure the default gateway (in the master
    HA router) by parsing the "virtual_routes" section of keepalived.conf file.
    The "virtual_routes" section is properly constructed for an IPv4 subnet, but
    requires a minor change for IPv6 subnets.

    Conflicts:
        neutron/agent/l3_ha_agent.py
        neutron/tests/functional/agent/test_l3_agent.py

    Closes-Bug: #1414937
    Change-Id: I54070e048577292d98d86fcc9ca8b9d3e72b4ebe
    (cherry picked from commit a1318ae187f1695e2e49bbde32eb75230e96aefe)