Usability: ironic 'node-list' shows maintenance mode as "True" or "False" but ironic node-set-maintenance accepts 'on' or 'off' only.

Bug #1414804 reported by Clint Byrum
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
python-ironicclient
Fix Released
Low
Rakesh H S

Bug Description

This is confusing. Suggest accepting True/False or listing on/off.

Revision history for this message
Dmitry Tantsur (divius) wrote :

Changing listing might break somebody, so accepting True/False should be an answer.

Changed in python-ironicclient:
status: New → Triaged
tags: added: low-hanging-fruit
Changed in python-ironicclient:
importance: Undecided → Low
Rakesh H S (rh-s)
Changed in python-ironicclient:
assignee: nobody → Rakesh H S (rh-s)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-ironicclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/150692

Changed in python-ironicclient:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-ironicclient (master)

Reviewed: https://review.openstack.org/150692
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=0f6bf9e94a4e86654ed024683f6cb376172b7994
Submitter: Jenkins
Branch: master

commit 0f6bf9e94a4e86654ed024683f6cb376172b7994
Author: Rakesh H S <email address hidden>
Date: Tue Jan 27 08:49:51 2015 -0800

    ironicclient node-set-maintenance to accept true/false

    ironicclient node-set-maintenance as of now accepts on/off, but this is not
    consistent with the API which accepts true/false.

    proposed changes to ironicclient to accept true/false for node-set-maintenance
    to maintain consistency.

    Change-Id: I93744384267b4670c7a14a90b14bd5afede45fc4
    Closes-Bug: #1414804

Changed in python-ironicclient:
status: In Progress → Fix Committed
Changed in python-ironicclient:
milestone: none → 0.7.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.