volume-attach "already attached" and "already detached" are not mutually exclusive

[sparr]

> nova volume-attach 81eef059-1490-4ec3-b0fc-b1b4e6380ee8 639e0a87-1190-42d4-b3a1-a385090aec06
ERROR: Invalid volume: already attached (HTTP 400) (Request-ID: req-1c51a40b-1015-4cee-b313-5dda524a3555)
> nova volume-detach 81eef059-1490-4ec3-b0fc-b1b4e6380ee8 639e0a87-1190-42d4-b3a1-a385090aec06
ERROR: Invalid volume: already detached (HTTP 400) (Request-ID: req-bb99c24e-1ca8-4f02-bb0a-9bb125857637)

I'm trying to resolve a much larger problem with my openstack environment, involving volume exporting, and I ran across this situation. Whatever the tests are for these two messages, they should be mutually exclusive. Maybe a third message is needed, for some intermediate state?

[Vincent Hou (houshengbo)]

Could you give me the detailed steps to reproduce this bug?
Which version of openstack are you using?

[Vincent Hou (houshengbo)]

The only condition for this issue to happen is that volume status is "available" and volume attach status is "attached".

[sparr (sparr0)]

Sadly one of the reproduction steps is "have the openstack host's kernel lock up, then hard reboot it", so it's non-trivial to accomplish. To resolve the problem we ended up having to dive into the mysql backend and update the volume statuses manually.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/164951

[Vincent Hou (houshengbo)]

If the status in the database has been changed unexpected, it may lead to this error.
I modified the check_detach before doing a detach, making the condition more strict to raise the exception. Hope it can reduce the possibility of this issue.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/164951
Reason: This patch has been stalled for quite a while, so I am going to abandon it to keep the code review queue sane. Please restore the change when it is ready for review.

[Sean McGinnis (sean-mcginnis)]

Unassigning due to no activity.