Bug #1414587 “Changing oslo library imports” : Bugs : Sahara

Andrey Pavlov (apavlov-n) on 2015-01-26

Changed in sahara:
assignee:	nobody → Andrey Pavlov (apavlov-n)

Sergey Reshetnyak (sreshetniak) on 2015-01-26

Changed in sahara:
milestone:	none → kilo-2
status:	New → In Progress
importance:	Undecided → Medium

Andrey Pavlov (apavlov-n) on 2015-01-27

Changed in python-saharaclient:
assignee:	nobody → Andrey Pavlov (apavlov-n)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-01-27: Fix proposed to python-saharaclient (master)

#1

Fix proposed to branch: master
Review: https://review.openstack.org/150295

Changed in python-saharaclient:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-01-28: Fix merged to python-saharaclient (master)

#2

Reviewed: https://review.openstack.org/150295
Committed: https://git.openstack.org/cgit/openstack/python-saharaclient/commit/?id=28a5c6f7a1556e20b6b5a2bcc74a21c7d23fdf58
Submitter: Jenkins
Branch: master

commit 28a5c6f7a1556e20b6b5a2bcc74a21c7d23fdf58
Author: Andrey Pavlov <email address hidden>
Date: Tue Jan 27 10:24:57 2015 +0300

Using oslo_* instead of oslo.*

Closes-bug: #1414587

Change-Id: I22b743b6e63bd847d5cc11b83229aa9810eaae38

Changed in python-saharaclient:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-01-30: Fix proposed to sahara (master)

#3

Fix proposed to branch: master
Review: https://review.openstack.org/151621

Sergey Lukjanov (slukjanov) on 2015-02-03

Changed in sahara:
milestone:	kilo-2 → kilo-3

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-02-05: Fix merged to sahara (master)

#4

Reviewed: https://review.openstack.org/148530
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=5c5491f9ded7a6d23b643fcace91f8057879d776
Submitter: Jenkins
Branch: master

commit 5c5491f9ded7a6d23b643fcace91f8057879d776
Author: Andrey Pavlov <email address hidden>
Date: Tue Jan 20 13:48:19 2015 +0300

Using oslo_* instead of oslo.*

    Changes:
    * using oslo_config instead of oslo.config
    * using oslo_concurrency instead of oslo.concurrency
    * using oslo_db instead of oslo.db
    * using oslo_i18n instead of oslo.i18n
    * using oslo_messaging instead of oslo.messaging
    * using oslo_middleware instead of oslo.middleware
    * using oslo_serialization instead of oslo.serialization
    * using oslo_utils instead of oslo.utils

Change-Id: Ib0f18603ca5b0885256a39a96a3620d05260a272
Closes-bug: #1414587

Changed in sahara:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-02-06: Fix proposed to sahara (master)

#5

Fix proposed to branch: master
Review: https://review.openstack.org/153500

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-02-07: Fix merged to sahara (master)

#6

Reviewed: https://review.openstack.org/153500
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=eb154fc0aa29b7891151c2611328fbff6bc43426
Submitter: Jenkins
Branch: master

commit eb154fc0aa29b7891151c2611328fbff6bc43426
Author: Andrey Pavlov <email address hidden>
Date: Fri Feb 6 12:28:45 2015 +0300

Adding missed oslo import change

Change-Id: Iee47dfd8fce1d0f1b3fa11ed523ca6d7dc593648
partially-bug: #1414587

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-02-10:

#7

Reviewed: https://review.openstack.org/151621
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=ee394be471a025c46e45d75c8943592051030ec3
Submitter: Jenkins
Branch: master

commit ee394be471a025c46e45d75c8943592051030ec3
Author: Andrey Pavlov <email address hidden>
Date: Wed Feb 4 12:44:14 2015 +0300

Adding hacking check to prevent old oslo namespace usage

Change-Id: I1b81c98bc3b3a3955e6255c5e4788cf43789c350
Partially-bug: #1414587

Sergey Lukjanov (slukjanov) on 2015-02-12

Changed in python-saharaclient:
importance:	Undecided → Medium
milestone:	none → 0.7.7
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2015-03-19

Changed in sahara:
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2015-04-30

Changed in sahara:
milestone:	kilo-3 → 2015.1.0

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-08-19: Fix proposed to sahara-tests (master)

#8

Fix proposed to branch: master
Review: https://review.openstack.org/357664

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-08-19: Fix merged to sahara-tests (master)

#9

Download full text (9.0 KiB)

Reviewed: https://review.openstack.org/357664
Committed: https://git.openstack.org/cgit/openstack/sahara-tests/commit/?id=e163f7925974ce7a74e29cbf83db7fb00103e470
Submitter: Jenkins
Branch: master

commit 87bae8585033bf371a936d2de330a89d791244ad
Author: Matthew Treinish <email address hidden>
Date: Tue Jun 28 11:53:22 2016 -0400

Remove unecessary decorators from private interface

    This commit removes the usage of the services decorators from the
    tempest plugin tests. That decorator is an internal interface and
    not meant for external consumption, and is now causing failures
    because of recent tempest changes. Plugins should only use documented
    stable interfaces. [1]

    Also the use of the decorator here actually adds nothing to the tests.
    They do 2 things, add a test attr to filter by service and add a skip
    check on the service availability. However both of these are already
    done, data_processing is already part of the test_id so filtering
    will just work and the skip check for sahara is baked into the base
    test class. So using this decorator does nothing except break the
    plugin.

[1] http://docs.openstack.org/developer/tempest/plugin.html#stable-tempest-apis-plugins-may-use

Change-Id: I45587d065c1b7b7f28feb29e8845f8f0f8405b8c

commit f4db8224967267e91abb05dd9c526318589f383b
Author: ZhiQiang Fan <email address hidden>
Date: Mon Apr 18 22:00:47 2016 +0800

update options mentioned in tempest readme

Some options have already been deprecated but still used in tempest
README.rst, let's use the new one.

Change-Id: Ic3bfb66b0898869149126c21aef0b2fd673385e2

commit f82c7db143bb7bf3c358e735f9646a17684ba5b6
Author: Luigi Toscano <email address hidden>
Date: Fri Feb 26 11:24:32 2016 +0100

Use the integrated tempest.lib module

    Tempest-lib has been reintegrated into tempest (as code, but it still provides
    a stable API). The old library is still available, but tempest tests are
    failing because when sahara is installed and exports the scenario tests
    for python clients, python-lib is not installed (it's correcly in
    test-requirements.txt, not requirements.txt), and tempest does not
    install tempest-lib anymore. Hence, fix the tests to use the new
    official location.

Change-Id: Iaded03ee387b4a0bbabb7bfe9e54d38e010d9c4f

commit 85ce728189d8f8a63843ebde5950a0c56233fa3a
Author: luhuichun <email address hidden>
Date: Tue Dec 1 14:09:22 2015 +0800

Replacing all hard coded cluster status using cluster_utils

Change-Id: I9550e98553da9f7bfc57923e44a789e07a912ff4
Closes-bug: 1517061

commit 0abdc18a94089bf698582daa051a96fd645935f3
Author: Evgeny Sikachev <email address hidden>
Date: Thu Nov 26 13:40:51 2015 +0300

Add missed checks for testing update method

    In tempest tests for saharaclient we have missed methods
    for checking update of templates.
    Closes-bug: #1520140

Change-Id: I8191e3344ecffd7a2ed442ba3d561741701c45e2

commit 80bfb9a469d2a289e903b19488214855b8a7fa94
Author: Evgeny Sikachev <email address hidden>
Date: Tue Nov 17 16:05:04 2015 +0300

Adding t...

Reviewed:  https://review.openstack.org/357664
Committed: https://git.openstack.org/cgit/openstack/sahara-tests/commit/?id=e163f7925974ce7a74e29cbf83db7fb00103e470
Submitter: Jenkins
Branch:    master

commit 87bae8585033bf371a936d2de330a89d791244ad
Author: Matthew Treinish <mtreinish@kortar.org>
Date:   Tue Jun 28 11:53:22 2016 -0400

Remove unecessary decorators from private interface
    
    This commit removes the usage of the services decorators from the
    tempest plugin tests. That decorator is an internal interface and
    not meant for external consumption, and is now causing failures
    because of recent tempest changes. Plugins should only use documented
    stable interfaces. [1]
    
    Also the use of the decorator here actually adds nothing to the tests.
    They do 2 things, add a test attr to filter by service and add a skip
    check on the service availability. However both of these are already
    done, data_processing is already part of the test_id so filtering
    will just work and the skip check for sahara is baked into the base
    test class. So using this decorator does nothing except break the
    plugin.
    
    [1] http://docs.openstack.org/developer/tempest/plugin.html#stable-tempest-apis-plugins-may-use
    
    Change-Id: I45587d065c1b7b7f28feb29e8845f8f0f8405b8c

commit f4db8224967267e91abb05dd9c526318589f383b
Author: ZhiQiang Fan <aji.zqfan@gmail.com>
Date:   Mon Apr 18 22:00:47 2016 +0800

update options mentioned in tempest readme
    
    Some options have already been deprecated but still used in tempest
    README.rst, let's use the new one.
    
    Change-Id: Ic3bfb66b0898869149126c21aef0b2fd673385e2

commit f82c7db143bb7bf3c358e735f9646a17684ba5b6
Author: Luigi Toscano <ltoscano@redhat.com>
Date:   Fri Feb 26 11:24:32 2016 +0100

Use the integrated tempest.lib module
    
    Tempest-lib has been reintegrated into tempest (as code, but it still provides
    a stable API). The old library is still available, but tempest tests are
    failing because when sahara is installed and exports the scenario tests
    for python clients, python-lib is not installed (it's correcly in
    test-requirements.txt, not requirements.txt), and tempest does not
    install tempest-lib anymore. Hence, fix the tests to use the new
    official location.
    
    Change-Id: Iaded03ee387b4a0bbabb7bfe9e54d38e010d9c4f

commit 85ce728189d8f8a63843ebde5950a0c56233fa3a
Author: luhuichun <huichun.lu@intel.com>
Date:   Tue Dec 1 14:09:22 2015 +0800

Replacing all hard coded cluster status using cluster_utils
    
    Change-Id: I9550e98553da9f7bfc57923e44a789e07a912ff4
    Closes-bug: 1517061

commit 0abdc18a94089bf698582daa051a96fd645935f3
Author: Evgeny Sikachev <esikachev@mirantis.com>
Date:   Thu Nov 26 13:40:51 2015 +0300

Add missed checks for testing update method
    
    In tempest tests for saharaclient we have missed methods
    for checking update of templates.
    Closes-bug: #1520140
    
    Change-Id: I8191e3344ecffd7a2ed442ba3d561741701c45e2

commit 80bfb9a469d2a289e903b19488214855b8a7fa94
Author: Evgeny Sikachev <esikachev@mirantis.com>
Date:   Tue Nov 17 16:05:04 2015 +0300

Adding tests for checking updating of templates
    
    Need add checks for testing updating of sahara resources
    
    Change-Id: Ifeb9a312236753884ef3f120f1ae579dcb77b4ed

commit 2e68007b00d00c9e7cffb48cdde426d5730db4b9
Author: Andrey Pavlov <apavlov@mirantis.com>
Date:   Fri Oct 16 11:34:55 2015 +0300

Fix tempest tests
    
    Sahara config group was changed from data_processing
    to data-processing
    
    Change-Id: I0a6686bfa1f14b18c17518b6ef2e6f5183fecebe
    Closes-bug: #1506781

commit 4f116d0fdfa90c179805755ecd962d4530d823c7
Author: Andrey Pavlov <apavlov@mirantis.com>
Date:   Wed Sep 30 16:56:32 2015 +0300

Fix of client tests in tempest
    
    python-saharaclient tests in tempest were fixed
    and documentation updated
    
    Change-Id: I6a5964b8ecd1e343c427ae7aefdadac5cfa26ad9
    Closes-bug: #1501347

commit 512b2078c1c083485b855bbbb8bf02e8861532db
Author: Luigi Toscano <ltoscano@redhat.com>
Date:   Fri Sep 18 14:13:04 2015 +0200

Adapt python client tests to use Tempest plugin interface
    
    Use the Tempest plugin interface for python client tests (which
    are already tempest-based) instead of copying the tests inside
    the tempest tree.
    
    Inspired by the same type of change applied to Manila,
    see Ie5ed64a6777ed1acf8dd56522c26705ae897596d
    
    Depends-On: I06f1e13207cc6d661c078c4c4cf1ae7974ecf3da
    Change-Id: I6073a528413aefd96882179a1eb8bbe715c6417b

commit a356fc3a96ae535d7532ddbfac0ae4d96dd721e7
Author: Luigi Toscano <ltoscano@redhat.com>
Date:   Thu Sep 17 12:40:15 2015 +0200

Python client tests: access to credentials/net clients
    
    Adapt to the latest changes in tempest master, and fix the
    access to the credentials and the network clients.
    
    The relevant changes seems to be (tempest):
    Credentials: I2f026e553f8c2c2a4cf2cb319bcd67e7d82e0479
    Network client: I1730adb3258557698dbe15658bb1c12f2292c2fd
    
    Change-Id: I7af04cdd6805e8e26e27355289fbfd81d384d9af

commit 5fc4c517146b2a6f532bde5b354c0947166235cc
Author: Sergey Reshetnyak <sreshetniak@mirantis.com>
Date:   Tue Mar 24 19:01:36 2015 +0300

Set up network client for tempest client tests
    
    Change-Id: I08e590390e84880beaa394daac2d5eaf32c254fc

commit b5ae7bdd13b5bc9b0675435979a7b07dbe93e7eb
Author: Jacob Bin Wang <wangbin@awcloud.com>
Date:   Wed Mar 18 09:29:40 2015 +0800

Fix order of arguments in assertEqual - Part1
    
    Some tests used incorrect order assertEqual(observed, expected).
    The correct order expected by testtools is:
        def assertEqual(self, expected, observed, message='')
    Changed to use the right order. Also if the order is wrong and
    expected value is None, change it to assertIsNone instead.
    
    It requires big changes and some tests change frequently.
    So I would do it in series of small CR.
    This part contains all changes except tests of plugins and service.
    
    Partial-Bug: #1259292
    
    Change-Id: Iefbb5f4b9efca35f7a2298f9f7f5b9de73fc260f

commit 9d62e637dd9083ded7759e41f9b42e876c70d2b6
Author: Jacob Bin Wang <wangbin@awcloud.com>
Date:   Thu Mar 19 11:23:24 2015 +0800

Fix log import error in tempest tests for Sahara
    
    Fix log import error in base class of client tests.
    Tempest now use olso.log for logging,
    instead of log module from tempest common or tempest-lib.
    
    Closes-bug: #1425835
    
    Change-Id: Idb1ea80af5f567e198380171b0c9216952b85b50

commit 0db1e946030853659065e6fb4a719b2677c10b09
Author: Sergey Reshetnyak <sreshetniak@mirantis.com>
Date:   Wed Mar 11 09:50:15 2015 +0300

Change imports after moving tempest common code
    
    All tempest common code migrated to tempest-lib
    
    Change-Id: I25203b5dfc73abafa1738669d20a7e270e542396

commit ce39d65861f36d861fd69ac6b0f51f7901c6bac0
Author: Sergey Reshetnyak <sreshetniak@mirantis.com>
Date:   Tue Mar 10 13:58:42 2015 +0300

Skip job_execution tempest client test
    
    Skip job_execution tempest test because bug #1430252 is not resolved
    
    Change-Id: I278c477e23de436ae584f9c6db5cb8ed708655ef
    Related-bug: #1430252

commit e31343f31c3b28cbfd9bf19a34d189319b485c25
Author: Sergey Reshetnyak <sreshetniak@mirantis.com>
Date:   Mon Mar 9 11:50:35 2015 +0300

Fix tempest tests for Sahara
    
    Fix getting network id in client tests
    
    Related-bug: #1425835
    
    Change-Id: I27d4746fd4225637cf0e808ca31399ec5019c508

commit 375e070be0eff13faf7d2f1823b826167bb17b5f
Author: Sergey Reshetnyak <sreshetniak@mirantis.com>
Date:   Thu Feb 26 15:35:05 2015 +0300

Fix tempest client tests in Sahara
    
    Change-Id: I60e09e79ec3a222b3257f0ee86b93ee2fc862c0e
    Closes-bug: #1425835

commit dd2d38369ae11ae154c694a84e0c26ffce59a2dc
Author: Andrey Pavlov <apavlov@mirantis.com>
Date:   Tue Jan 20 13:48:19 2015 +0300

Using oslo_* instead of oslo.*
    
    Changes:
    * using oslo_config instead of oslo.config
    * using oslo_concurrency instead of oslo.concurrency
    * using oslo_db instead of oslo.db
    * using oslo_i18n instead of oslo.i18n
    * using oslo_messaging instead of oslo.messaging
    * using oslo_middleware instead of oslo.middleware
    * using oslo_serialization instead of oslo.serialization
    * using oslo_utils instead of oslo.utils
    
    Change-Id: Ib0f18603ca5b0885256a39a96a3620d05260a272
    Closes-bug: #1414587

commit 08f6043dca880f56173c6f1b828bb0de79d6fac7
Author: Sergey Reshetnyak <sreshetniak@mirantis.com>
Date:   Mon Jan 26 18:27:56 2015 +0300

Fix getting not registered images
    
    Return only registered images in Sahara API
    
    Change-Id: If86ad7c7d237d162886b99865f0e17f3e0b6679d
    Closes-bug: #1414000

commit d758afd2c97f325dead6622cc043ea52159f1d76
Author: Andrey Pavlov <apavlov@mirantis.com>
Date:   Wed Dec 10 10:03:08 2014 +0300

Saharaclient tests for tempest
    
    implements bp: saharaclient-tests-in-tempest
    
    Change-Id: I1a491d0ee566e3bd4ab1957ac400806c60602686

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-04: Fix included in openstack/sahara-tests 0.3.0

#10

This issue was fixed in the openstack/sahara-tests 0.3.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-10: Fix included in openstack/python-saharaclient 0.8.0

#11

This issue was fixed in the openstack/python-saharaclient 0.8.0 release.

Affects		Status	Importance	Assigned to	Milestone
	Python client library for Sahara	Fix Released	Medium	Andrey Pavlov	Python client library for Sahara 0.7.7
	Sahara	Fix Released	Medium	Andrey Pavlov	Sahara 2015.1.0 "kilo"

Sahara

Changing oslo library imports

Bug Description

Other bug subscribers

Remote bug watches