uncleare purpose of CO "talkover"

[Daniel Schürmann]

The "Talkover" CO has an unclear purpose, since it is part of every EngineChannel, but it evaluated different in EngineMicrophone and elsewhere.
In EngineMicrophone it mutes the output at the other Channels it is not evaluated.

I see two options to solve this:
1.) remove "talkover" from EngineChannel and add it to EngineMicrophone only

2.) remove the Muting form Engine Microphone and Introduce a different logic:
Add to master mix like ...
master=0, takover=0 mute
master=0, takover=1 use talkover gain
master=1, takover=0 use normal gain
master=1, takover=1 use talkover gain

For now, I prefer 2. because it really adds talkover capability to all EngineChannels

Any comments?

[Daniel Schürmann (daschuer)]

I am about to fix it that way:

Master and talkover sets the routing in addition to the mixer orientation.
Maste=1 Aux like routing though xFader
Talkover=1 xFader bypass

      /--------------------------------------\0---------\
     / /-L-------x--\ 1 \
    / /----------+--M-----------+---+-----------+---|sidechain
   1 1 \-R-------X--/ \---|master
--/0----------/0----|mute mic in master
 talkcover master orientation xFader

[Daniel Schürmann (daschuer)]

My ascii art is messed up. See here of a well formated version https://github.com/mixxxdj/mixxx/pull/474

[Daniel Schürmann (daschuer)]

It turns out we have an additional degree of freedom: The "mute" CO
What should enabled when it is enabled:
Channel is not added to the X-Fader but PFL should still work.
What is in the talkover case? Do we have a us case for it?
For now I will treat the mute as an inverse "master" and as a zero switch for the volume slider:
Result: Talkover will work regardless of Mute

[Sean M. Pappalardo (pegasus-renegadetech)]

Talkover is intended to reduce the volume of all source channels to allow the mic to be louder than everything else. Master's volume needs to remain untouched so the mic is still heard.

[Sean M. Pappalardo (pegasus-renegadetech)]

So if Master is muted, no audio should come out of Mixxx at all.

[Daniel Schürmann (daschuer)]

Sorry for my confusing post.
Currently we have no [master],mute CO. Do we need one?
We have a mute CO for every single channel so for microphones as well.

Currently a microphones is muted by its mute CO even tough takeover is enabled.
A muted mic is still the ducking key.
The volume CO has no effect. No PFL for mics.

After my proposed changes we would have two paths for ALL channels:
1. though the xFader with "master" C0 = 1 -> ducked by talkover, with individual volume and mute
2. bypass xFader with "talkover" CO = 1 -> Its the ducking key, volume allays 1 no mute

Mics are default at path2:
"master" CO is 0 by default, the talkover CO can be controlled from the Skin.
PFL works always for all channels.

Does this fulfill all requirements and use-cases?

[Daniel Schürmann (daschuer)]

The final routing is described here:
https://github.com/mixxxdj/mixxx/pull/474#issuecomment-72337890

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7829