Horizon: incorrect error message when VM deletion failed

[Danny Choi]

nova-manage version: 2014.2.2

Issue: incorrect error message when VM delete failed. It should be "delete", not "launch".

e.g. ERROR: Failed to launch instance XYZ. Please try again later. [Error: delete_port_precommit failed.].

[Wu Wenxiang (wu-wenxiang)]

Hello, After checking code, I found scenario maybe as below:
1. "Failed to launch instance" only in get_instance_error() in openstack_dashboard/dashboards/project/instances/tables.py
2. get_instance_error only called in UpdateRow::get_data, also in openstack_dashboard/dashboards/project/instances/tables.py
3. all the operation below related to UpdateRow::get_data, include delete, so "ERROR: Failed to launch instance" should be changed to "Unable to retrieve instance information"
    class Meta:
        name = "instances"
        verbose_name = _("Instances")
        status_columns = ["status", "task"]
        row_class = UpdateRow
        table_actions_menu = (StartInstance, StopInstance, SoftRebootInstance)
        table_actions = (LaunchLink, TerminateInstance, InstancesFilterAction)
        row_actions = (StartInstance, ConfirmResize, RevertResize,
                       CreateSnapshot, SimpleAssociateIP, AssociateIP,
                       SimpleDisassociateIP, EditInstance,
                       DecryptInstancePassword, EditInstanceSecurityGroups,
                       ConsoleLink, LogLink, TogglePause, ToggleSuspend,
                       ResizeLink, LockInstance, UnlockInstance,
                       SoftRebootInstance, RebootInstance,
                       StopInstance, RebuildInstance, TerminateInstance)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/149881

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/149881
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=94ce4953bdbe102018aae51f4c63e9d57555d067
Submitter: Jenkins
Branch: master

commit 94ce4953bdbe102018aae51f4c63e9d57555d067
Author: Wu Wenxiang <[e-mail]>
Date: Sun Jan 25 07:17:59 2015 -0800

    Incorrect error message when VM deletion failed

    Correct error message from "Failed to launch instance" to "Failed to perform
    requested operation on instance, the instance has an error status" in file:
    openstack_dashboard/dashboards/project/instances/tables.py.

    Change-Id: Ieb3f8c83cd55a74b76cd442418a86c53180feed9
    Closes-Bug: #1414164