Style editor color automatically converted wrongly

Bug #1414121 reported by Knut-Olav Hoven
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Brewtarget
Fix Committed
Medium
Mik Firestone

Bug Description

Brewtarget 2.1.0

Configured to use metric/Europe units.

The color fields are labelled EBC, but when I enter a number and exits the field (with tab, or by mouse) the value is automatically converted using some algorithm that looks like SRM->EBC.
This occurs also every time I open the style editor.

This issue looks kinda similar to #1170088, but the other way around... increasing the values instead of reducing them.

Revision history for this message
Mik Firestone (mikfire) wrote :

What happens when you switch the color units from "default" to "srm" and then back to "ebc"? I am wondering if this is a confusion caused by the label being wrong -- so you think it is ebc but the code is thinking it is srm.

Changed in brewtarget:
assignee: nobody → Mik Firestone (mikfire)
Revision history for this message
Eivind Olsen (eivind-u) wrote :

I thought I'd add that this also happens here, testet with Brewtarget 2.1.0 on both Mac OS X and Linux.
If I change the color units to SRM, the "Color (Lovibond)" field keeps the value, but if I turn color units back to EBC the contents of that field (now called "Color (EBC)" is recalculated and replaced every time I enter something there, or even if I just TAB through that field.

Revision history for this message
Mik Firestone (mikfire) wrote :

This was resolved in MR99. If one of the other devs would test and verify my results, I would appreciate it.

Changed in brewtarget:
importance: Undecided → Medium
milestone: none → 2.2.0
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.