Some unit tests are not running

Bug #1414083 reported by Pavlo Shchelokovskyy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
huangtianhua

Bug Description

Since we've split AWS and OS versions of WaitCondition- and Volume-related resources, unit tests for those resources are actually not executed as they are not being discovered.

Changed in heat:
assignee: nobody → Pavlo Shchelokovskyy (pshchelo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/150804

Changed in heat:
status: New → In Progress
Angus Salkeld (asalkeld)
Changed in heat:
importance: Undecided → High
milestone: none → kilo-2
Changed in heat:
assignee: Pavlo Shchelokovskyy (pshchelo) → huangtianhua (huangtianhua)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/150804
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=5f3f379422053829a406c80b291fcbe37c970075
Submitter: Jenkins
Branch: master

commit 5f3f379422053829a406c80b291fcbe37c970075
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Fri Jan 23 19:03:23 2015 +0200

    Enable some unit tests back

    Since split between AWS and OS WaitConidtion/Volume resources unit tests
    for those resources were not running as they were not discovered.

    During this time some changes were merged that actually broke some
    tests (mostly the mocking) so this patch fixes those broken tests too.

    Some AWS WaitConidtion tests were testing the handle_update method,
    which has no sense now as it no longer returns a TaskRunner instance.
    These tests were modified to use the general resource.update method.

    One test in AWS volumes is modified to use mocked ServerConstraint,
    which is added to base TestCase as are stubs for other constraints.
    Another test in AWS volumes was using a dumb monkey-patching
    instead of proper mock, leading to clashes during concurrent test runs.

    Change-Id: Ie765eab75de835d5dec94024f1d90197f1723b4d
    Closes-Bug: #1414083

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.