get_all_physical_volumes() returns incorrect results when pvs output contains extra ':' characters

[Joe D'Andrea]

get_all_physical_volumes() runs:

pvs --noheadings --unit=g -o vg_name,name,size,free --separator : --nosuffix

This can produce a variable number of fields if the 'name' incorporates ':', as in the following:

cinder-volumes-array-lun-0:/dev/disk/by-path/ip-10.8.77.11:3260-iscsi-iqn.1984-05.com.dell:powervault.md3600i.6f01faf000eb1b540000000053c487b0-lun-0:931.01:931.01

This use of ":" is not through any customization, but appears to be default behavior elsewhere in linux.

Note: This is already being addressed by https://review.openstack.org/#/c/148002/ - filing a bug to support backporting upon approval.

[Joe D'Andrea (jdandrea)]

Already have a patch in review.

[Mike Perez (thingee)]

Stable freeze will be January 30th. http://lists.openstack.org/pipermail/openstack-dev/2015-January/054924.html

[Joe D'Andrea (jdandrea)]

Thanks, Mike. This is my first patch as well. (No pressure *grin*.) I'm making adjustments to tests right now and ensuring everything passes. I'll cross-link the patch to this bug on my next commit/amend.

[Joe D'Andrea (jdandrea)]

Mike: The patch looks good. One more comment I'm awaiting a response to. Other than that I think it just needs more verification besides Jenkins.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/148002
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=456a6f81d8da03ef852575e1e6053dae6958dd43
Submitter: Jenkins
Branch: master

commit 456a6f81d8da03ef852575e1e6053dae6958dd43
Author: Joe D'Andrea <email address hidden>
Date: Fri Jan 16 21:26:09 2015 +0000

    Changed pvs separator from ':' to '|' to support names with ':'.

    get_all_physical_volumes() runs:

    pvs --noheadings --unit=g -o vg_name,name,size,free
        --separator : --nosuffix

    Which can produce a variable number of fields if the 'name'
    incorporates ':', as in the following:

    cinder-volumes-array-lun-0:/dev/disk/by-path/ip-10.8.77.11:3260-
        iscsi-iqn.1984-05.com.dell:powervault.md3600i.6f01faf000eb1b
        540000000053c487b0-lun-0:931.01:931.01

    Change-Id: Ia5442af2a06a004ff1af58ce08b816506b369f22
    Closes-Bug: 1414076