libvirt driver creates wrong console device for system z

[Markus Zoeller (markus_z)]

The system z platform needs a console device for the log file of an
instance. A (manual[*]) regression test showed that this is not the case
with master from 2015-01-22. The guest.cpu.arch is None which leads
to the creation of a wrong device.

Wrong domain XML:
    <domain type="kvm">
        [...]
        <devices>
            [...]
            <serial type="file">
                <source path="/path/to/console.log" />
            </serial>
            <console type="pty">
                <target type="sclp" />
            </console>
            [...]
        </devices>
    </domain>

Correct domain XML:
    <domain type="kvm">
        [...]
        <devices>
            [...]
            <console type="file">
                <source path="/path/to/console.log" />
                <target type="sclplm" />
            </console>
            <console type="pty">
                <target type="sclp" />
            </console>
            [...]
        </devices>
    </domain>

[*] The CI environment for this platform is still under development.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/149653

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/149653
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=88d516080173ecf2aa2f982fb4a4c01defa232b4
Submitter: Jenkins
Branch: master

commit 88d516080173ecf2aa2f982fb4a4c01defa232b4
Author: Markus Zoeller <email address hidden>
Date: Fri Jan 23 16:23:54 2015 +0100

    libvirt: fix console device for system z for log file

    The system z platform needs a console device for the log file of an
    instance. A (manual) regression test showed that this is not the case
    with master from 2015-01-22. The guest.cpu.arch is 'None' which leads
    to the creation of a wrong device. The bug was introduced with commit
    11a2ed096

    This fix uses the libvirt utils to decide which architecture has to be
    considered.

    Closes-bug: 1414038

    Change-Id: I97dc55e6fca0b2491d4a9bc81366f9c92d39002a