VMware store: Attribute error while retrying image upload

[Sabari Murugesan]

In case of unauthenticated session, vmware store retries to upload the image data but fails when seeking to reposition the file.

2015-01-22 19:12:31.883 20624 ERROR glance.api.v1.upload_utils [e5be8f01-4bbb-4a1c-9721-495615e5e5cb 65dc7965ee13438e9ae706d4d42d2f65 087a197802df458dac65c1060a8e4cd4 - - -] Failed to upload image fa4a3308-917a-4899-8905-66333955cdfb
2015-01-22 19:12:31.883 20624 TRACE glance.api.v1.upload_utils Traceback (most recent call last):
2015-01-22 19:12:31.883 20624 TRACE glance.api.v1.upload_utils File "/opt/stack/glance/glance/api/v1/upload_utils.py", line 107, in upload_data_to_store
2015-01-22 19:12:31.883 20624 TRACE glance.api.v1.upload_utils context=req.context)
2015-01-22 19:12:31.883 20624 TRACE glance.api.v1.upload_utils File "/opt/stack/glance_store/glance_store/backend.py", line 318, in store_add_to_backend
2015-01-22 19:12:31.883 20624 TRACE glance.api.v1.upload_utils context=context)
2015-01-22 19:12:31.883 20624 TRACE glance.api.v1.upload_utils File "/opt/stack/glance_store/glance_store/_drivers/vmware_datastore.py", line 359, in add
2015-01-22 19:12:31.883 20624 TRACE glance.api.v1.upload_utils image_file.rewind()
2015-01-22 19:12:31.883 20624 TRACE glance.api.v1.upload_utils File "/opt/stack/glance_store/glance_store/_drivers/vmware_datastore.py", line 124, in rewind
2015-01-22 19:12:31.883 20624 TRACE glance.api.v1.upload_utils self.data.seek(0)
2015-01-22 19:12:31.883 20624 TRACE glance.api.v1.upload_utils AttributeError: 'CooperativeReader' object has no attribute 'seek'
2015-01-22 19:12:31.883 20624 TRACE glance.api.v1.upload_utils

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/149515

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/149515
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=632ce4000a303ece3dc0e497a7bdaaa72d396648
Submitter: Jenkins
Branch: master

commit 632ce4000a303ece3dc0e497a7bdaaa72d396648
Author: Sabari Kumar Murugesan <email address hidden>
Date: Thu Jan 22 16:06:36 2015 -0800

    Remove retry on failed uploads to VMware datastore

    VMware store retries to upload the image data but fails when
    seeking to reposition the file. Since the image_file is not
    seekable, we can never retry from the beginning. Also, the
    backend datastore server does not support resumable upload.

    Thus,
    1. Removing the retry logic in store.add().
    2. Replace non-existing UnexpectedStatus with BackendException.

    Closes-Bug: #1413852

    Change-Id: I453a14cb832c07c8cd932a3db7b4a34a80a73116