Address Details pages consistency

Bug #1413823 reported by Rob Cresswell
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Unassigned

Bug Description

Details pages are inconsistent across Horizon:
- Different title styles - Firewalls, Port Details, Instance Details: <ID>
- Different alignment - some indented, others aligned hard left
- Varying subheadings - Overview, info, information, general info etc. All referring to the same thing.

We need a pass over the styling of the Details pages to make the look & feel consistent throughout.

Invision examples of cleanup: https://invis.io/P546WHCCK

Changed in horizon:
assignee: nobody → Rob Cresswell (robcresswell)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/151762

Changed in horizon:
status: New → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154834

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154839

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/154834
Reason: Duplicate patch

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/154849

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154871

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154876

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/154876

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/154839

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/154871

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/154849

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/151762
Reason: Changing solution

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/212152

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/234173

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/234315

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/212152
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7a58d15aec5f2327fb7df9c9cffd2f06a019d837
Submitter: Jenkins
Branch: master

commit 7a58d15aec5f2327fb7df9c9cffd2f06a019d837
Author: Rob Cresswell <email address hidden>
Date: Wed Aug 12 19:47:59 2015 +0100

    Navigation + cleanup for details pages

    Adds a common detail page and a breadcrumb templatetag. The breadcrumb
    templatetag defaults to displaying the panel name and the existing page
    title, which is usually name_or_id. The templatetag can also access the
    context, and accepts a "custom_breadcrumb", for complex nested pages or
    customised layouts.

    This type of navigation is also useful for small devices (mobile/
    tablet), providing logical direction that isn't dependant on the
    sidebar being displayed.

    Currently implemented in Images, Volumes (simple breadcrumb), Ports and
    Subnets (more complex nesting).

    This approach has been chosen as manipulation of the URLs was seen as
    undesirable, making request.path too unreliable. Furthermore, the
    templatetag seperation means this could easily be used in other views.

    NOTE: The network details page itself will be updated following the
    resolution of https://bugs.launchpad.net/horizon/+bug/1416838

    Change-Id: I7443b2ffa61560e5d1fd4d6d91b11201f1db6fac
    Partial-Bug: 1413823

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/234173
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f38ddf20323ca1e278caa37013871b65013a0e81
Submitter: Jenkins
Branch: master

commit f38ddf20323ca1e278caa37013871b65013a0e81
Author: Rob Cresswell <email address hidden>
Date: Thu Sep 24 12:26:38 2015 +0100

    Add breadcrumb to more details pages

    This patch adds basic Breadcrumb nav to the detail pages for Data
    Processing, Databases, Metadata Definitions and Routers.

    Change-Id: I114e93799b957db39cbe0d4e49d3e6869bc9d92d
    Partial-Bug: 1413823

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/243566

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/234315
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=3c322c368bbbe0f11303a0aae6f3f63fe257d3e5
Submitter: Jenkins
Branch: master

commit 3c322c368bbbe0f11303a0aae6f3f63fe257d3e5
Author: Rob Cresswell <email address hidden>
Date: Tue Oct 13 13:13:15 2015 +0100

    Add firewall detail actions and breadcrumb nav

    This patch adds the standard table row actions to firewalls, along with
    basic breadcrumb navigation.

    Also makes minor changes to workflow step titles and adds missing
    translation to the Ports breadcrumb.

    Change-Id: I3941d8ae8b75ecd1e85b4f140f24aa0f8eddb5cc
    Closes-Bug: 1457437
    Partial-Bug: 1413823

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/243566
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d861d6848ba6746a4706253fb02adf29ab9f5034
Submitter: Jenkins
Branch: master

commit d861d6848ba6746a4706253fb02adf29ab9f5034
Author: Rob Cresswell <email address hidden>
Date: Fri Oct 30 11:17:52 2015 +0900

    Add breadcrumbs to final details pages

    This patch adds the breadcrumb navigation to the final few details
    pages: Users, Load Balancers, Projects, Hypervisors.

    - Small redesigns the Load Balancer page to make the Member/Monitor
    listings more readable
    - Small redesign of Monitor Details to make Pools list more readable
    - Adds missing translation wrapper to subnets breadcrumb

    At this point, all Details pages should now use the breadcrumb format,
    with the exception of Network Details, which is waiting on
    https://bugs.launchpad.net/horizon/+bug/1416838

    Closes-Bug: 1413823
    Closes-Bug: 1100318
    Change-Id: I3a1de6d24dfd49ae2e28107e9de76bbd9d972162

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
importance: Undecided → Low
milestone: none → mitaka-1
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b1

This issue was fixed in the openstack/horizon 9.0.0.0b1 development milestone.

Changed in horizon:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.