Ironic Inspector

Introspection results might disappear if list_ports fails

Bug #1413552 reported by Dmitry Tantsur
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic Inspector
Fix Released
High
Dmitry Tantsur
Ironic Inspector 1.1.0

Bug Description

add_node is called only after list_ports, if the latter fails we won't get any results. add node_cache.add_attribute for adding macs and call add_node earlier (and before going to green thread)

Dmitry Tantsur (divius)
Changed in ironic-discoverd:
assignee: nobody → Dmitry "Divius" Tantsur (divius)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-discoverd (master)

Fix proposed to branch: master
Review: https://review.openstack.org/154534

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-discoverd (master)

Reviewed: https://review.openstack.org/154534
Committed: https://git.openstack.org/cgit/stackforge/ironic-discoverd/commit/?id=37b0b4209e0c257324600944579a459f6513c714
Submitter: Jenkins
Branch: master

commit 37b0b4209e0c257324600944579a459f6513c714
Author: Dmitry Tantsur <email address hidden>
Date: Tue Feb 10 16:46:10 2015 +0100

    Make sure we always notify user about an introspect call error

    Previously if list_ports failed, there would be no notifications.
    Introduced NodeInfo.add_attribute(), so that we can separate
    adding node to cache and adding it's attributes.

    Change-Id: Ia654d1a047e94d91522c606bc00941951d9afb10
    Closes-Bug: #1413552

Changed in ironic-discoverd:
status: In Progress → Fix Committed
Dmitry Tantsur (divius)
Changed in ironic-inspector:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.