Incorrect volume snapshot mocking in quota tests

Bug #1413480 reported by Kieran Spear
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Kieran Spear

Bug Description

In openstack_dashboard/test/tests/quotas.py we're using self.snapshots as the return value for volume_snapshot_list, which is a list of Glance snapshots. It should be self.cinder_volume_snapshots.

         cinder.volume_snapshot_list(IsA(http.HttpRequest), opts).AndReturn(self.snapshots.list())

Kieran Spear (kspear)
Changed in horizon:
assignee: nobody → Kieran Spear (kspear)
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/149150

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/149150
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d54e7b91bbbda036e845f47e32aff0a0d7e77e26
Submitter: Jenkins
Branch: master

commit d54e7b91bbbda036e845f47e32aff0a0d7e77e26
Author: Kieran Spear <email address hidden>
Date: Sat Oct 26 19:03:53 2013 +1100

    Fix incorrect mocking in quota tests

    We're using self.snapshots as the return value for volume_snapshot_list,
    which is a list of Glance snapshots. It should be
    self.cinder_volume_snapshots.

    Also change the assert to assertItemsEqual since we're dealing with
    dictionaries.

    Closes-bug: 1413480
    Change-Id: I9632490e94c5d5cd435363c74a2ec65546a9c29f

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.