OpenStack Heat

Race condition in setting tempurl key

Bug #1413366 reported by Steve Baker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Steve Baker
OpenStack Heat 2015.1.0 "kilo"
Juno
Fix Released
Undecided
Unassigned
OpenStack Heat 2014.2.4

Bug Description

SwiftClientPlugin.get_temp_url has the potential to race with itself when storing a new tempurl key to the swift account, leading to tempurls being built with a key that has been overridden.

Steve Baker (steve-stevebaker)
no longer affects: python-heatclient
Changed in heat:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Steve Baker (steve-stevebaker)
milestone: none → kilo-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/149044

Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/149044
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=7401c030ff03f6b994541b9f5faf81735774e4b3
Submitter: Jenkins
Branch: master

commit 7401c030ff03f6b994541b9f5faf81735774e4b3
Author: Steve Baker <email address hidden>
Date: Thu Jan 22 09:45:05 2015 +1300

    Always fetch temp URL key before generation

    SwiftClientPlugin.get_temp_url has the potential to race with
    itself when storing a new tempurl key to the swift account,
    leading to tempurls being built with a key that has been
    overridden.

    This change always fetches the key from swift before creating a
    temp URL.

    Change-Id: Id5897fdd834cc5d3b74fda8d2317d084a5564c51
    Closes-Bug: #1413366

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: kilo-2 → 2015.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/244948

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/juno)

Reviewed: https://review.openstack.org/244948
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=b2c2677359f71c3feddd8bcfeafabe009338ca0e
Submitter: Jenkins
Branch: stable/juno

commit b2c2677359f71c3feddd8bcfeafabe009338ca0e
Author: Steve Baker <email address hidden>
Date: Thu Jan 22 09:45:05 2015 +1300

    Always fetch temp URL key before generation

    SwiftClientPlugin.get_temp_url has the potential to race with
    itself when storing a new tempurl key to the swift account,
    leading to tempurls being built with a key that has been
    overridden.

    This change always fetches the key from swift before creating a
    temp URL.

    Change-Id: Id5897fdd834cc5d3b74fda8d2317d084a5564c51
    Closes-Bug: #1413366

tags: added: in-stable-juno
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.