Making Better Use of CStoreEditor

[Jason Stephenson]

Evergreen backend services make extensive use of CStoreEditor. In a number of places, these CStoreEditor instances are created with an open database transaction (xact=>1). These transactions are sometimes not closed, particularly when they are used for "authoritative" search and retrieve from the database. These hanging transactions could cause problems for the cstore service if the drones remain connected as a result. This could lead to drones not responding to new requests for the timeout period (usually 6 seconds).

I have created a branch in the working repository, collab/dyrcona/lp1413336_making_better_use_of_cstoreeditor, where we can work on closing these open transactions. We should not run into much trouble working together on the same branch as long as we follow a few rules:

1. We split up who is working on which service.
2. We never commit changes to more than 1 service in 1 commit.

The second rule will make testing easier as well, since a tester can cherry-pick commits for a single service and focus on one thing.

Below is the URL for the collab branch for those who want that format.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/dyrcona/lp1413336_making_better_use_of_cstoreeditor