Spaces in attack box disappear

[wl-zocker]

Discovered in r7363:
When you open the attack box, there are spaces between the number of soldiers and the slash. When you change the number (either by sliding the slider or by clicking on a number), the spaces disappear. See attached screenshot for clarification.

[GunChleoc (gunchleoc)]

I can't reproduce this on a debug build, Ubuntu 14.04.

[Launchpad Janitor (janitor)]

[Expired for widelands because there has been no activity for 60 days.]

[SirVer (sirver)]

Cannot repro. Is this still a thing?

[wl-zocker (wl-zocker)]

I still have this issues on different OS:
- r7434 on Win7, from Tino's page (release)
- r7431 on Ubuntu 14.04, from the daily ppa (release)
- r7434 on Ubuntu 14.04, self-compiled from scratch (debug)

Any idea what it might depend on?

[SirVer (sirver)]

Maybe a translations issue? Have you tried other locales?

[wl-zocker (wl-zocker)]

It was indeed a problem with the German translation; I fixed it. The string is not translatable before update_attack is called. I think it should be fixed for consistency.

[SirVer (sirver)]

Is there a gettext _() missing somewhere? Do you know where exactly in the code?

[wl-zocker (wl-zocker)]

here: http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/src/wui/attack_box.cc#L122

The update function:
m_text_soldiers->set_text((boost::format(_("%1% / %2%")) % m_slider_soldiers->get_value() % max_attackers).str());

The initialization:
sprintf(buf, "%u / %u", max_attackers > 0 ? 1 : 0, max_attackers);

Simply adding an underscore would create a new/different translation, so a replacement is needed (I do not know the difference/which one should be preferred).

[GunChleoc (gunchleoc)]

Do the initialization with:

(boost::format(_("%1% / %2%")) % max_attackers > 0 ? 1 : 0 % max_attackers).str()

[GunChleoc (gunchleoc)]

Merge request sent. Thanks for tracking this one down!

[wl-zocker (wl-zocker)]

This is fix committed now, isn't it?

[GunChleoc (gunchleoc)]

Yes it is - forgot to change the bug status.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.