"trust_id" must be attached to execution or trigger objects

Bug #1413124 reported by Renat Akhmerov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
High
Nikolay Makhotkin

Bug Description

Now "trust_id" is attached to workflow object. This is wrong because, for example, if Mistral needs to upload standard workflows (provided out of the box) it doesn't have any user auth info to build a trust. If we use Mistral admin credentials from config this is wrong as well because users will be able to run workflows with those credentials (for example, if I run "create_instance" workflow directly).

The suggestion is remove trust_id from workflow model and attach it to execution and trigger object. In case if execution is created by trigger its "trust_id" must be reused when creating execution object.

Changed in mistral:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Nikolay Makhotkin (nmakhotkin)
milestone: none → kilo-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148856

Changed in mistral:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/148856
Committed: https://git.openstack.org/cgit/stackforge/mistral/commit/?id=fdfee071c96a3cf230fe51298258fa2992a65691
Submitter: Jenkins
Branch: master

commit fdfee071c96a3cf230fe51298258fa2992a65691
Author: Nikolay Mahotkin <email address hidden>
Date: Wed Jan 21 12:32:30 2015 +0300

    Fixing problem with trust creation

    Closes-Bug: #1413124

    Change-Id: I5de648fdcf56afcd74e15b3652ac8a13a2a7d37c

Changed in mistral:
status: In Progress → Fix Committed
Changed in mistral:
status: Fix Committed → Fix Released
Changed in mistral:
milestone: kilo-2 → 2015.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.