IloPXEDeploy.validate() is redendant

Bug #1412269 reported by Naohiro Tamura
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Wishlist
Naohiro Tamura

Bug Description

IloPXEDeploy.validate() has just two lines of the following code.
The method parent of parent class, PXEDeploy.validate() has called
driver_utils.validate_boot_mode_capability(task.node).
So IloPXEDeploy.validate() is not necessary.

      class IloPXEDeploy(pxe.PXEDeploy):
        def validate(self, task):
          driver_utils.validate_boot_mode_capability(task.node)
          super(IloPXEDeploy, self).validate(task)

Changed in ironic:
assignee: nobody → Naohiro Tamura (naohirot)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148136

Changed in ironic:
status: New → In Progress
Dmitry Tantsur (divius)
Changed in ironic:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/148136
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=844bf3b4339002af915312b4dab9bf411ce19f63
Submitter: Jenkins
Branch: master

commit 844bf3b4339002af915312b4dab9bf411ce19f63
Author: Naohiro Tamura <email address hidden>
Date: Sat Jan 17 23:35:42 2015 +0900

    Remove IloPXEDeploy.validate()

    Removed IloPXEDeploy.validate(), because the method of the parent
    class, PXEDeploy.validate(), has already implemented the code which it
    added.

    Change-Id: I534e8a2d84fcf2d8a94a5cc90f0b091f872333f9
    Closes-Bug: #1412269

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.