Rhythmbox playlists broken

[Daniel Schürmann]

Rhythmbox playlist are shown in the library tree, but not in the table view. The view is completely empty, no tracks, no headers.

[Daniel Schürmann (daschuer)]

This is a regression since https://github.com/mixxxdj/mixxx/commit/b20906ddea7acc7febd6735363eb00fb3585e973

[Owen Williams (ywwg)]

hm, I don't have rhythmbox so I'm not sure how to test this.

[Owen Williams (ywwg)]

(anything obvious in the logs?)

[Daniel Schürmann (daschuer)]

No, sorry. Is the Tractor feature effected too?

The easiest way would be just to install it.

Attached you find an empty Rhythmbox DB + an empty playlist.

Just place to ~/.local/share/rhythmbox

[Owen Williams (ywwg)]

It turns out I do have an old rhythmbox database, and the music displays fine for me in current trunk. My playlist also appears. For the files you provided, the database is empty and the playlists are all empty or search-based so I'm not sure what you expect to appear.

[Owen Williams (ywwg)]

maybe your database got messed up somehow? if you open up mixxxdb.sqlite and run this query, what do you get?

select * from settings where name like "%header_state_pb%";

[Daniel Schürmann (daschuer)]

Yes, you are right, a fresh database works es desired.
Is there an migration issue?

Attached you find the results from the query above.

[Owen Williams (ywwg)]

rhythmbox_bad definitely looks messed up, but there isn't actually any migration -- if mixxx doesn't see a _pb header state, it generates one from the defaults. It sounds like what is needed is an error-handling case where if the protobuf can't be read or is empty, it generates headers from default.

I don't know how the headers got in to that state, though.

[Owen Williams (ywwg)]

I pushed a change that should detect if the header state proto is unhealthy: if it has all the columns hidden or if there are no columns listed at all. If this happens, the default header state should be restored.

[Daniel Schürmann (daschuer)]

Can confirm, It is fixed now with my original library as well.
https://github.com/mixxxdj/mixxx/commit/5824fb6daadcdc9f5ec4b47fd85409b697e5574d
Thank you.

[Owen Williams (ywwg)]

Try rearranging your headers in a way that you recognize. Then, see if when you reset mix they revert to default again. If so, there is something wrong with the round-tripping (I do have tests for that, though, so that would be surprising)

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7815