Grayed-out progress bars in sidepane [$50]

Bug #1411975 reported by Giulio Sant
94
This bug affects 19 people
Affects Status Importance Assigned to Milestone
Files
Fix Released
Medium
Victor Martinez
elementary Stylesheet
Fix Released
Medium
Danielle Foré

Bug Description

After the latest gtk update, I've noticed the following visual glitch. There are cases in which it's as if the sidepane in Files lost focus and the progress bars of the mounted volumes appear grayed out. This can be reproduced by clicking on an empty area in the file manager. The normal appearance (blue bars) is restored as soon as I hover the mouse pointer over the sidepane.
See screenshot.

Related branches

Revision history for this message
Giulio Sant (giulio-sant) wrote :
tags: added: appearance sidebar
Changed in pantheon-files:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Danielle Foré (danrabbit) wrote :

Marking as "incomplete" in the stylesheet. I can't seem to affect it from .progressbar or anything like that. Not sure how it's getting its colors. Most likely something to do with the :focus:selected change

Changed in egtk:
status: New → Incomplete
Changed in egtk:
status: Incomplete → Invalid
Changed in pantheon-files:
milestone: none → freya-0.3.1
Revision history for this message
Bilal Elmoussaoui (bilal-elmoussaoui) wrote :

@Daniel Fore if you use any other theme (that is not based on elementary theme of course) you' will not have this issue. So yeah it's a CSS issue.

Revision history for this message
Danielle Foré (danrabbit) wrote : Re: Grayed-out progress bars in sidepane [$25]
summary: - Grayed-out progress bars in sidepane (Files)
+ Grayed-out progress bars in sidepane [$25]
tags: added: bounty
Cody Garver (codygarver)
Changed in pantheon-files:
milestone: 0.2.1 → freya-0.3.1
Revision history for this message
Danielle Foré (danrabbit) wrote :

@bil Except that's not the problem. The problem is that the code is trying to get the :selected style alone. While this would work in previous versions of the stylesheet (and may work for other stylsheets), it won't work anymore because we now distinguish between :selected and :selected:focus. This is an a11y feature.

summary: - Grayed-out progress bars in sidepane [$25]
+ Grayed-out progress bars in sidepane [$50]
Revision history for this message
Felipe Escoto (philip.scott) wrote :

Changing lines 53-62 of gtk-widgets.css with the following fixed it on my end, and i haven't noticed any side-effects

*:selected,
*:selected:focus {
    background-color: @theme_selected_bg_color;
    color: @theme_selected_fg_color;
}

Revision history for this message
Danielle Foré (danrabbit) wrote :

@phillip As I explained above, this is not a proper solution. Distinguishing between :selected and :selected:focus is an *accessibility feature* and will not be changed.

Cody Garver (codygarver)
Changed in pantheon-files:
milestone: 0.2.2 → freya-0.3.1
Cody Garver (codygarver)
Changed in pantheon-files:
status: Confirmed → Fix Committed
assignee: nobody → Victor Martinez (victored)
Changed in egtk:
assignee: nobody → Daniel Fore (danrabbit)
importance: Undecided → Medium
milestone: none → freya-0.3.1
status: Invalid → Fix Committed
Cody Garver (codygarver)
Changed in egtk:
status: Fix Committed → Fix Released
Cody Garver (codygarver)
Changed in pantheon-files:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.