Some floatingIP parameters are incorrect(1/3)

Bug #1411462 reported by Yushiro FURUKAWA
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-api-site
Fix Released
Undecided
watanabe.isao

Bug Description

In http://developer.openstack.org/api-ref-networking-v2.html, POST: /v2.0/floatingips
following contents need to be fixed in "floatingIP".
---------------------------------------------------------------
1. "status" does not exist in Response parameters matrix.
  -> Insert following column:
       Parameter: "status"
       Style: plain
       Type: xsd:string
       Description: "The floatingip status."
2. Due to 1., "status" does not exist in JSON parameters example.
  -> Insert following parameter into JSON parameter:
       "status": "ACTIVE",
   Also, format is better to match the Response parameters.
3. "id" is unnecessary in Request parameter matrix.
4. In response paramaters "id" needs to be changed to "router_id"
5. Due to 4., in response paramater "id" should be added:
-> Insert following column:
        Parameter: "id"
        Style: plain
        Type: csapi:uuid
        Description: "The floatingip ID."

---------------------------------------------------------------
[current execution result]
$ curl -i -X POST -H "content-type:application/json" -d '{"floatingip": {"floating_network_id": "9ee8cf55-ffc0-42dc-a6f8-3f6ef6e18be6", "port_id": "4a1e1bd7-8df9-45db-aa46-d7de0f2f2269"}}' -H "x-auth-token:$TOKEN" http://
 192.168.122.96:9696/v2.0/floatingips
 HTTP/1.1 201 Created
 Content-Type: application/json; charset=UTF-8
 Content-Length: 371
 X-Openstack-Request-Id: req-0d420cec-0192-4b4c-8eed-9781d6bdc127
 Date: Tue, 03 Mar 2015 14:53:37 GMT

{"floatingip": {"floating_network_id": "9ee8cf55-ffc0-42dc-a6f8-3f6ef6e18be6", "router_id": "dcca90a8-e627-49c7-9d68-6461925d28b2", "fixed_ip_address": "192.168.12.1", "floating_ip_address": "192.168.12.3", "tenant_id": "f592c903fa8a492db8cf784ecb1e793c", "status": "DOWN", "port_id": "4a1e1bd7-8df9-45db-aa46-d7de0f2f2269", "id": "8f6e9a03-8ef3-422e-bb2e-9d9283f406de"}}

---------------------------------------------------------------

Changed in neutron:
assignee: nobody → Yushiro FURUKAWA (y-furukawa-2)
affects: neutron → openstack-api-site
description: updated
Changed in openstack-api-site:
status: New → In Progress
description: updated
description: updated
tags: added: neutron
tags: added: api-site
tags: added: floatingip
description: updated
Changed in openstack-api-site:
assignee: Yushiro FURUKAWA (y-furukawa-2) → nobody
Changed in openstack-api-site:
assignee: nobody → watanabe.isao (watanabe.isao)
description: updated
summary: - Some floatingIP parameters are incorrect
+ Some floatingIP parameters are incorrect(1/3)
description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to api-site (master)

Fix proposed to branch: master
Review: https://review.openstack.org/160231

description: updated
description: updated
description: updated
description: updated
description: updated
description: updated
description: updated
description: updated
Revision history for this message
Anne Gentle (annegentle) wrote :

I'd like to see this set to Confirmed, and there's a floating ip id that I don't think should be in the fix. For the sake of process and reviewers, please give more explanation on where in the neutron code you floating ip id.

Tom Fifield (fifieldt)
Changed in openstack-api-site:
milestone: none → kilo
Revision history for this message
watanabe.isao (watanabe.isao) wrote :

The status has been add in the following fix, but not fixed in API referrence:
https://github.com/openstack/neutron/commit/a1b08606f2a73339b31ab49d172ae8793d76a55b#diff-945dff00e4b503c82a401a364883fcaa
 authored on 15 Jan 2014

And I will add a current excution result as well.

description: updated
Revision history for this message
watanabe.isao (watanabe.isao) wrote :

About the incorrectly described "id" as "router ID", and miss of "ID of floatingip".
Found a related recent fix:
https://github.com/openstack/neutron/commit/93012915a3445a8ac8a0b30b702df30febbbb728#diff-945dff00e4b503c82a401a364883fcaa

 - neutron/db/l3_db.py

authored on 9 Oct 2014

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to api-site (master)

Reviewed: https://review.openstack.org/160231
Committed: https://git.openstack.org/cgit/openstack/api-site/commit/?id=3e55be0ae46863acdd15fa1399a16b06546d9082
Submitter: Jenkins
Branch: master

commit 3e55be0ae46863acdd15fa1399a16b06546d9082
Author: watanabe.isao <email address hidden>
Date: Mon Mar 2 14:44:24 2015 +0900

    Fix parameters of POST floatingip

    Change-Id: I460e0e641495aeecfb7f5d17a96c4b54104d2ffa
    Closes-Bug: #1411462

Changed in openstack-api-site:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.