zfssa driver attach functionality is broken with appliance version 2013.1.3.0

[abhiram moturi]

The zfssa storage appliances have a new minor release 2013.1.3.0 for the software.
This update has a change in the REST service which might cause attach to fail for the zfssa iscsi driver.

in the zfssarest.py get_lun() function we try to get the assignednumber for a lun
...
'number': val['lun']['assignednumber']
....
For earlier versions this val['lun']['assignednumber'] was an int but in the update, it is an array in order to support multiple assigned numbers.
In our case since volume can only be attached to one instance, it will always be an array of 1 number and the fix is pretty simple.

[Juan Zuluaga (juan-c-zuluaga)]

I would change the synopsis, and be more specific about the issue.
This synopsis implies that the whole driver is not compatible.
It's only the attach functionality that it's affected by the new release of the s/w appliance.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/147576

[abhiram moturi (abhiram-moturi)]

oops sorry i modified after seeing your comment but you already modified it and it didnt update on my side then

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/147576
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=d47171701646db0bfca5f0026b3a6db08176bde6
Submitter: Jenkins
Branch: master

commit d47171701646db0bfca5f0026b3a6db08176bde6
Author: abhiram_moturi <email address hidden>
Date: Thu Jan 15 11:31:53 2015 -0500

    Fix zfssa driver volume attach to work with latest zfssa software

    This fixes the volume attach issue of the zfssa driver
    with the latest zfssa software release and makes it work
    for all zfssa versions.

    Change-Id: I4b9ceb7788c112ee5998f24b00a07d4346bc6275
    Closes-Bug: #1411291

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/147827

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/147827
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=32f7788b1fcfc55824e93e0e25b47e1c25fa779f
Submitter: Jenkins
Branch: stable/juno

commit 32f7788b1fcfc55824e93e0e25b47e1c25fa779f
Author: abhiram_moturi <email address hidden>
Date: Thu Jan 15 11:31:53 2015 -0500

    Fix zfssa driver volume attach to work with latest zfssa software

    This fixes the volume attach issue of the zfssa driver
    with the latest zfssa software release and makes it work
    for all zfssa versions.

    Change-Id: I4b9ceb7788c112ee5998f24b00a07d4346bc6275
    Closes-Bug: #1411291
    (cherry picked from commit d47171701646db0bfca5f0026b3a6db08176bde6)