Cinder

test cases in tests.targets.test_lio_driver fail for systems without cinder-rtstool installed

Bug #1411029 reported by Jay Bryant on 2015-01-14

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Cinder	Fix Released	High	Mitsuhiro Tanino	Cinder 2015.1.0 "kilo"

Bug Description

It was discovered today after this patch merged: https://github.com/openstack/cinder/commit/73363c1cacac15e8caee0df44db4a7dfdea9cc35 That the new test cases would fail if cinder-rtstool wasn't installed. The following failures would be encountered:

======================================================================
FAIL: cinder.tests.targets.test_lio_driver.TestLioAdmDriver.test_create_export
----------------------------------------------------------------------
Traceback (most recent call last):
_StringException: Traceback (most recent call last):
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/tests/targets/test_lio_driver.py", line 28, in setUp
    configuration=self.configuration)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/volume/targets/lio.py", line 39, in __init__
    self._verify_rtstool()
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/volume/targets/lio.py", line 74, in _verify_rtstool
    utils.execute('cinder-rtstool', 'verify')
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/utils.py", line 142, in execute
    return processutils.execute(*cmd, **kwargs)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/.venv/lib/python2.7/site-packages/oslo_concurrency/processutils.py", line 208, in execute
    env=env_variables)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/.venv/lib/python2.7/site-packages/eventlet/green/subprocess.py", line 47, in __init__
    subprocess_orig.Popen.__init__(self, args, 0, *argss, **kwds)
  File "/usr/local/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/local/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
Traceback (most recent call last):
_StringException: Empty attachments:
  stderr
  stdout

Traceback (most recent call last):
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/tests/targets/test_lio_driver.py", line 28, in setUp
    configuration=self.configuration)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/volume/targets/lio.py", line 39, in __init__
    self._verify_rtstool()
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/volume/targets/lio.py", line 74, in _verify_rtstool
    utils.execute('cinder-rtstool', 'verify')
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/utils.py", line 142, in execute
    return processutils.execute(*cmd, **kwargs)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/.venv/lib/python2.7/site-packages/oslo_concurrency/processutils.py", line 208, in execute
    env=env_variables)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/.venv/lib/python2.7/site-packages/eventlet/green/subprocess.py", line 47, in __init__
    subprocess_orig.Popen.__init__(self, args, 0, *argss, **kwds)
  File "/usr/local/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/local/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

Traceback (most recent call last):
_StringException: Empty attachments:
stderr
stdout

======================================================================
FAIL: cinder.tests.targets.test_lio_driver.TestLioAdmDriver.test_create_iscsi_target
----------------------------------------------------------------------
Traceback (most recent call last):
_StringException: Traceback (most recent call last):
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/tests/targets/test_lio_driver.py", line 28, in setUp
    configuration=self.configuration)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/volume/targets/lio.py", line 39, in __init__
    self._verify_rtstool()
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/volume/targets/lio.py", line 74, in _verify_rtstool
    utils.execute('cinder-rtstool', 'verify')
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/utils.py", line 142, in execute
    return processutils.execute(*cmd, **kwargs)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/.venv/lib/python2.7/site-packages/oslo_concurrency/processutils.py", line 208, in execute
    env=env_variables)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/.venv/lib/python2.7/site-packages/eventlet/green/subprocess.py", line 47, in __init__
    subprocess_orig.Popen.__init__(self, args, 0, *argss, **kwds)
  File "/usr/local/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/local/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
Traceback (most recent call last):
_StringException: Empty attachments:
  stderr
  stdout

Traceback (most recent call last):
_StringException: Empty attachments:
stderr
stdout

======================================================================
FAIL: cinder.tests.targets.test_lio_driver.TestLioAdmDriver.test_create_iscsi_target_already_exists
----------------------------------------------------------------------
Traceback (most recent call last):
_StringException: Traceback (most recent call last):
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/tests/targets/test_lio_driver.py", line 28, in setUp
    configuration=self.configuration)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/volume/targets/lio.py", line 39, in __init__
    self._verify_rtstool()
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/volume/targets/lio.py", line 74, in _verify_rtstool
    utils.execute('cinder-rtstool', 'verify')
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/utils.py", line 142, in execute
    return processutils.execute(*cmd, **kwargs)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/.venv/lib/python2.7/site-packages/oslo_concurrency/processutils.py", line 208, in execute
    env=env_variables)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/.venv/lib/python2.7/site-packages/eventlet/green/subprocess.py", line 47, in __init__
    subprocess_orig.Popen.__init__(self, args, 0, *argss, **kwds)
  File "/usr/local/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/local/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
Traceback (most recent call last):
_StringException: Empty attachments:
  stderr
  stdout

Traceback (most recent call last):
_StringException: Empty attachments:
stderr
stdout

======================================================================
FAIL: cinder.tests.targets.test_lio_driver.TestLioAdmDriver.test_ensure_export
----------------------------------------------------------------------
Traceback (most recent call last):
_StringException: Traceback (most recent call last):
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/tests/targets/test_lio_driver.py", line 28, in setUp
    configuration=self.configuration)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/volume/targets/lio.py", line 39, in __init__
    self._verify_rtstool()
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/volume/targets/lio.py", line 74, in _verify_rtstool
    utils.execute('cinder-rtstool', 'verify')
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/utils.py", line 142, in execute
    return processutils.execute(*cmd, **kwargs)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/.venv/lib/python2.7/site-packages/oslo_concurrency/processutils.py", line 208, in execute
    env=env_variables)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/.venv/lib/python2.7/site-packages/eventlet/green/subprocess.py", line 47, in __init__
    subprocess_orig.Popen.__init__(self, args, 0, *argss, **kwds)
  File "/usr/local/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/local/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
Traceback (most recent call last):
_StringException: Empty attachments:
  stderr
  stdout

Traceback (most recent call last):
_StringException: Empty attachments:
stderr
stdout

======================================================================
FAIL: cinder.tests.targets.test_lio_driver.TestLioAdmDriver.test_get_target
----------------------------------------------------------------------
Traceback (most recent call last):
_StringException: Traceback (most recent call last):
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/tests/targets/test_lio_driver.py", line 28, in setUp
    configuration=self.configuration)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/volume/targets/lio.py", line 39, in __init__
    self._verify_rtstool()
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/volume/targets/lio.py", line 74, in _verify_rtstool
    utils.execute('cinder-rtstool', 'verify')
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/utils.py", line 142, in execute
    return processutils.execute(*cmd, **kwargs)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/.venv/lib/python2.7/site-packages/oslo_concurrency/processutils.py", line 208, in execute
    env=env_variables)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/.venv/lib/python2.7/site-packages/eventlet/green/subprocess.py", line 47, in __init__
    subprocess_orig.Popen.__init__(self, args, 0, *argss, **kwds)
  File "/usr/local/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/local/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
Traceback (most recent call last):
_StringException: Empty attachments:
  stderr
  stdout

Traceback (most recent call last):
_StringException: Empty attachments:
stderr
stdout

======================================================================
FAIL: cinder.tests.targets.test_lio_driver.TestLioAdmDriver.test_get_target_chap_auth
----------------------------------------------------------------------
Traceback (most recent call last):
_StringException: Traceback (most recent call last):
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/tests/targets/test_lio_driver.py", line 28, in setUp
    configuration=self.configuration)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/volume/targets/lio.py", line 39, in __init__
    self._verify_rtstool()
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/volume/targets/lio.py", line 74, in _verify_rtstool
    utils.execute('cinder-rtstool', 'verify')
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/utils.py", line 142, in execute
    return processutils.execute(*cmd, **kwargs)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/.venv/lib/python2.7/site-packages/oslo_concurrency/processutils.py", line 208, in execute
    env=env_variables)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/.venv/lib/python2.7/site-packages/eventlet/green/subprocess.py", line 47, in __init__
    subprocess_orig.Popen.__init__(self, args, 0, *argss, **kwds)
  File "/usr/local/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/local/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
Traceback (most recent call last):
_StringException: Empty attachments:
  stderr
  stdout

Traceback (most recent call last):
_StringException: Empty attachments:
stderr
stdout

======================================================================
FAIL: cinder.tests.targets.test_lio_driver.TestLioAdmDriver.test_verify_backing_lun
----------------------------------------------------------------------
Traceback (most recent call last):
_StringException: Traceback (most recent call last):
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/tests/targets/test_lio_driver.py", line 28, in setUp
    configuration=self.configuration)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/volume/targets/lio.py", line 39, in __init__
    self._verify_rtstool()
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/volume/targets/lio.py", line 74, in _verify_rtstool
    utils.execute('cinder-rtstool', 'verify')
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/cinder/utils.py", line 142, in execute
    return processutils.execute(*cmd, **kwargs)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/.venv/lib/python2.7/site-packages/oslo_concurrency/processutils.py", line 208, in execute
    env=env_variables)
  File "/home/jsbryant/cinder-dev/oslo_db_namespace/.venv/lib/python2.7/site-packages/eventlet/green/subprocess.py", line 47, in __init__
    subprocess_orig.Popen.__init__(self, args, 0, *argss, **kwds)
  File "/usr/local/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/local/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
Traceback (most recent call last):
_StringException: Empty attachments:
  stderr
  stdout

Traceback (most recent call last):
_StringException: Empty attachments:
stderr
stdout

Some fakes need to be created to avoid this.

Jay Bryant (jsbryant) on 2015-01-14

Changed in cinder:
status:	New → Confirmed
importance:	Undecided → High

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-01-14: Related fix proposed to cinder (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/147338

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-01-15: Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/147352

Changed in cinder:
assignee:	nobody → Mitsuhiro Tanino (mitsuhiro-tanino)
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-01-15: Related fix merged to cinder (master)

Reviewed: https://review.openstack.org/147338
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=e35cbfa22b45685c1f9d1bc5e54362d63a8ef944
Submitter: Jenkins
Branch: master

commit e35cbfa22b45685c1f9d1bc5e54362d63a8ef944
Author: Mike Perez <email address hidden>
Date: Wed Jan 14 15:47:26 2015 -0800

Skip LIO target unit tests until mocked

    Unit tests are calling out to cinder-rtstool, which breaks in most
    environments. We need these calls mocked out properly before being
    reenabled.

Change-Id: Ic25828361d9c30c4e1aa37b630d8ad272a78977b
Related-Bug: #1411029

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-01-15: Fix merged to cinder (master)

Reviewed: https://review.openstack.org/147352
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=94d9c9c8e5df18589d233f4a713f2f2059bdf92d
Submitter: Jenkins
Branch: master

commit 94d9c9c8e5df18589d233f4a713f2f2059bdf92d
Author: Mitsuhiro Tanino <email address hidden>
Date: Wed Jan 14 19:59:54 2015 -0500

Add mock for cinder-rtstool call in tests.targets.test_lio_driver

    Unit tests in tests.targets.test_lio_driver are calling out to
    cinder-rtstool.
    change-id Ic25828361d9c30c4e1aa37b630d8ad272a78977b skips this
    unit test to avoid failure of tests.
    This patch reverts this change and adds mock for calling of
    cinder-rtstool to reenable the unit tests.

Change-Id: I11dc07f692b5ba07484595c980f82bbdd2140d24
Closes-Bug: #1411029

Changed in cinder:
status:	In Progress → Fix Committed

Thierry Carrez (ttx) on 2015-02-05

Changed in cinder:
milestone:	none → kilo-2
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2015-04-30

Changed in cinder:
milestone:	kilo-2 → 2015.1.0

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.