LateNight has three library widgets

Bug #1410888 reported by Owen Williams
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
Owen Williams

Bug Description

This is due to the use of sizeawarestack. It causes problems with memory usage and control object connections in the UI.

There are two possible fixes:
1. Make the library widget a singleton, and reparent it as necessary in the UI depending on which widgets are visible
2. Rework LateNight so it only has one library.

I'm currently pursuing both avenues with roughly equal amounts of frustration. Right now the second approach is blocked by lp#1410885.

Revision history for this message
Owen Williams (ywwg) wrote :

approach 2 is not possible. It was based on the idea of taking the library widget out of the sizeawarestack and then hiding it only when it's turned off. But the sizeawarestack needs to know about the library to calculate how big it is -- without it, the library just squishes the stack to nothing. If the stack is allocated a certain amount of size, then there is a big empty void where the effects and samplers could be, even if they are hidden. So this doesn't work.

Revision history for this message
Owen Williams (ywwg) wrote :

Singleton widgets will work! progress: https://github.com/mixxxdj/mixxx/pull/463

Revision history for this message
Owen Williams (ywwg) wrote :

fixed

Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7807

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.