Heat benchmarks stop working

[Boris Pavlovic]

Traceback (most recent call last):
  File "/opt/stack/new/rally/rally/benchmark/runners/base.py", line 77, in _run_scenario_once
    method_name)(**kwargs) or scenario_output
  File "/opt/stack/new/rally/rally/benchmark/scenarios/heat/stacks.py", line 73, in create_and_delete_stack
    stack = self._create_stack(stack_name, template)
  File "/opt/stack/new/rally/rally/benchmark/scenarios/base.py", line 261, in func_atomic_actions
    f = func(self, *args, **kwargs)
  File "/opt/stack/new/rally/rally/benchmark/scenarios/heat/utils.py", line 100, in _create_stack
    check_interval=CONF.benchmark.heat_stack_create_poll_interval)
  File "/opt/stack/new/rally/rally/benchmark/utils.py", line 104, in wait_for
    resource = update_resource(resource)
  File "/opt/stack/new/rally/rally/benchmark/utils.py", line 67, in _get_from_manager
    status=status, fault=msg)
GetResourceErrorStatus: Resource <Stack {u'parent': None, u'disable_rollback': True, u'description': u'No description', u'links': [{u'href': u'http://104.130.172.248:8004/v1/1e8b247b51864a3e9c7861c0236d59a2/stacks/rally_stack_jyojhxj/635bee10-3c7c-47d5-8c88-69822136677f', u'rel': u'self'}], u'stack_status_reason': u"Resource CREATE failed: Forbidden: Policy doesn't allow ((rule:create_router and (rule:create_router:external_gateway_info and (rule:create_router:external_gateway_info:network_id))) and rule:create_router:distributed) to be performed.", u'stack_name': u'rally_stack_jyojhxj', u'outputs': [], u'timeout_mins': None, u'creation_time': u'2015-01-14T09:49:46Z', u'capabilities': [], u'notification_topics': [], u'parameters': {u'OS::project_id': u'1e8b247b51864a3e9c7861c0236d59a2', u'OS::stack_id': u'635bee10-3c7c-47d5-8c88-69822136677f', u'OS::stack_name': u'rally_stack_jyojhxj', u'image': u'cirros-0.3.2-x86_64-uec', u'cidr': u'11.11.11.0/24', u'flavor': u'm1.tiny', u'public_net': u'public'}, u'stack_owner': None, u'stack_status': u'CREATE_FAILED', u'updated_time': None, u'id': u'635bee10-3c7c-47d5-8c88-69822136677f', u'template_description': u'No description'}> has CREATE_FAILED status:

==========================================================================

Reproduce for Heat.
Create a stack with template:

heat_template_version: 2013-05-23
parameters:
  public_net:
    type: string
    default: public
resources:
  router:
    type: OS::Neutron::Router
    properties:
      external_gateway_info:
        network: {get_param: public_net}

during create you will get error:

| router | 3b19dedb-1207-4103-a774-f5d0f0bbff43 | Forbidden: Policy doesn't allow ((rule:create_router and (rule:create_router:external_gateway_info and (rule:create_router:external_gateway_info:network_id))) and rule:create_router:distributed) to be performed. | CREATE_FAILED | 2015-01-14T16:32:23Z |

Same may be reproduced with template:

heat_template_version: 2013-05-23
parameters:
  public_net:
    type: string
    default: public
resources:
  router:
    type: OS::Neutron::Router

It happens due to patch https://review.openstack.org/#/c/143921/, and default value for Distributed property and requires ADMIN user.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/147242

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/147242
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=4797811cf392f2992c1e8c2abea383c74ab1fdde
Submitter: Jenkins
Branch: master

commit 4797811cf392f2992c1e8c2abea383c74ab1fdde
Author: Sergey Kraynev <email address hidden>
Date: Thu Jan 15 08:55:31 2015 -0500

    Remove default for DISTRIBUTED property

    Default option is used always during creation of the router resource
    and this option requires admin priviledges.
    We should delete it, because it prevents creating router with other
    (non admin) properties or router resource without defined properties.
    Also according to neutron documentation default value for distribution
    is None: http://specs.openstack.org/openstack/neutron-specs/specs/juno/
    neutron-ovs-dvr.html#data-model-impact

    Closes-Bug: #1410788
    Change-Id: Ic13e24c2e4ff13608872439187650cb4cdebb2df

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/148457

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/148457
Committed: https://git.openstack.org/cgit/stackforge/rally/commit/?id=405c678c129cf3a74bd4a5e854bf90b856df05d0
Submitter: Jenkins
Branch: master

commit 405c678c129cf3a74bd4a5e854bf90b856df05d0
Author: Sergey Kraynev <email address hidden>
Date: Tue Jan 20 02:44:44 2015 -0500

    Re-enabling Heat/Neutron resources test

    Fix for this bug was merged in Heat and now we can enable this test in
    rally.

    Change-Id: Idc8ad50628c7adb9a5837a480b57830d08fbb278
    Closes-Bug: #1410788