TIMEOUT_SCALING_FACTOR is ignored in migration tests

[Roman Podoliaka]

After reusing oslo.db migrations test cases TIMEOUT_SCALING_FACTOR is now ignored and general timeout value is used in migration test cases (currently, OS_TEST_TIMEOUT=160 in .testr.conf), which may cause sporadic test failures depending on the test node load.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/146943

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/146943
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2ca45a61ef5ce77db962ee6a2302dc2d35e3e5bd
Submitter: Jenkins
Branch: master

commit 2ca45a61ef5ce77db962ee6a2302dc2d35e3e5bd
Author: Roman Podoliaka <email address hidden>
Date: Tue Jan 13 14:20:59 2015 +0200

    tests: fix handling of TIMEOUT_SCALING_FACTOR

    After reusing oslo.db common migration test cases
    TIMEOUT_SCALING_FACTOR is now ignored and the general timeout value
    (OS_TEST_TIMEOUT=160 defined in .testr.conf) is used for migration
    test cases too, which may lead to occasional test failures depending
    on the load of a test node.

    In order to fix this we just need the migration test cases to inherit
    Nova base test case again, so that Timeout fixture is properly used.

    Closes-Bug: #1410235

    Change-Id: Ic83475730a14aa5079b85b02ade76f49a0a15b39

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/155280

[OpenStack Infra (hudson-openstack)]

Change abandoned by Roman Podoliaka (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/155280
Reason: in favor of: https://review.openstack.org/#/c/156996

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/158364
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d240b281129111d568d420d64450bbd0aac7a561
Submitter: Jenkins
Branch: master

commit d240b281129111d568d420d64450bbd0aac7a561
Author: Roman Podoliaka <email address hidden>
Date: Mon Feb 23 19:12:34 2015 +0200

    Fix the order of base classes in migrations test cases

    Next release of oslo.db is going to break Nova migrations tests: when
    a test case cleanup is run it fails to fetch 'schema' attribute of
    oslo.db base test case sets in its setup. The problem is that Nova
    base test case intentionally removes all attributes from a test case
    class instance in its cleanup callback (to ensure there are no memory
    leaks).

    Inheritance from Nova base test case was actually added when fixing
    LP #1410235, so that TIMEOUT_SCALING_FACTOR attribute would be
    handled properly (at that time it was done directly in Nova base test
    case setUp(), and now it's a separate fixture).

    So in order for Nova unit tests to work correctly with new release of
    oslo.db we need either to remove inheritance from Nova base test case
    or to change the order of base classes to achieve the 'proper' MRO
    for migration test cases. The latter can actually be problematic as
    we also need to ensure TIMEOUT_SCALING_FACTOR is still handled
    properly and not overridden by oslotest base test case.

    Related-Bug: #1410235

    Change-Id: I5c7d2a391425766a5e8fd61a532b1a1e7d410770