policy classes parameters documentation incorrect

[Mike Dorman]

Policy configuration through ::nova::policy (and similarly for the other services' modules) does not work if you use the $policies parameter format as is documented in the comments.

The comments on the ::nova::policy class indicate that the policies hash should be in this format:

{
  'nova-context_is_admin' => {
    'context_is_admin' => 'true'
  },
  'nova-default' => {
    'default' => 'rule:admin_or_owner'
  }
}

... which is given directly to create_resources.

However, in order for this to work properly, the hash given to create_resources should look like:

{
  'nova-context_is_admin' => {
    'key' => 'context_is_admin',
    'value' => 'true'
  },
  'nova-default' => {
    'key' => 'default',
    'value' => 'rule:admin_or_owner'
  }
}

If the user is providing a hash to ::nova::policy of the correct format, then all will be well. But if the user is providing a format as indicated in the comments, then the Puppet run will fail with:

Error: Invalid parameter context_is_admin on Openstacklib::Policy::Base[nova-context_is_admin] on node xxxxx

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/146635

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/146637

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/146638

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mike Dorman (<email address hidden>) on branch: master
Review: https://review.openstack.org/146635
Reason: Going after the wrong problem here. See updated bug report.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mike Dorman (<email address hidden>) on branch: master
Review: https://review.openstack.org/146637
Reason: Going after the wrong problem here. See updated bug report.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mike Dorman (<email address hidden>) on branch: master
Review: https://review.openstack.org/146638
Reason: Going after the wrong problem here. See updated bug report.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/146660

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/146662

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/146664

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/146660
Committed: https://git.openstack.org/cgit/stackforge/puppet-nova/commit/?id=96b96f33939862543e62695b1dff14b80d893c33
Submitter: Jenkins
Branch: master

commit 96b96f33939862543e62695b1dff14b80d893c33
Author: Mike Dorman <email address hidden>
Date: Mon Jan 12 15:22:06 2015 -0700

    Correct docs on format for nova::policy data

    Correct the format of the $policies parameter to nova::policy.
    That parameter is passed directly to create_resources, so it needs
    to be in a format acceptable to that.

    Just updating docs here as anyone already using the policy classes
    are likely not using the (incorrectly) documented format, anyway.

    Change-Id: I774678f0b49ee05b6aee6a5565302377d8eae186
    Closes-bug: 1409897

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/146662
Committed: https://git.openstack.org/cgit/stackforge/puppet-glance/commit/?id=ad5bb3d76b98b847bac5ed2467a46173343a1264
Submitter: Jenkins
Branch: master

commit ad5bb3d76b98b847bac5ed2467a46173343a1264
Author: Mike Dorman <email address hidden>
Date: Mon Jan 12 15:27:20 2015 -0700

    Correct docs on format for glance::policy data

    Correct the format of the $policies parameter to glance::policy.
    That parameter is passed directly to create_resources, so it needs
    to be in a format acceptable to that.

    Just updating docs here as anyone already using the policy classes
    are likely not using the (incorrectly) documented format, anyway.

    Change-Id: I80f1f832db124eef3bfd75907e4a2dcb5a5effca
    Closes-bug: 1409897

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/146664
Committed: https://git.openstack.org/cgit/stackforge/puppet-neutron/commit/?id=6d2aa10d8f8ed2dc05ee300e067e431d02d2209e
Submitter: Jenkins
Branch: master

commit 6d2aa10d8f8ed2dc05ee300e067e431d02d2209e
Author: Mike Dorman <email address hidden>
Date: Mon Jan 12 15:27:50 2015 -0700

    Correct docs on format for neutron::policy data

    Correct the format of the $policies parameter to neutron::policy.
    That parameter is passed directly to create_resources, so it needs
    to be in a format acceptable to that.

    Just updating docs here as anyone already using the policy classes
    are likely not using the (incorrectly) documented format, anyway.

    Change-Id: Ib69e2e421b216d6087ad47c198067667db89cc33
    Closes-bug: 1409897

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/187320

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/187383

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/187398

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/187320
Committed: https://git.openstack.org/cgit/stackforge/puppet-glance/commit/?id=a1468e4c735a98288dbdbe6c0fd2eae8a132fc1a
Submitter: Jenkins
Branch: stable/juno

commit a1468e4c735a98288dbdbe6c0fd2eae8a132fc1a
Author: Mike Dorman <email address hidden>
Date: Mon Jan 12 15:27:20 2015 -0700

    Correct docs on format for glance::policy data

    Correct the format of the $policies parameter to glance::policy.
    That parameter is passed directly to create_resources, so it needs
    to be in a format acceptable to that.

    Just updating docs here as anyone already using the policy classes
    are likely not using the (incorrectly) documented format, anyway.

    Change-Id: I80f1f832db124eef3bfd75907e4a2dcb5a5effca
    Closes-bug: 1409897
    (cherry picked from commit ad5bb3d76b98b847bac5ed2467a46173343a1264)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/187383
Committed: https://git.openstack.org/cgit/stackforge/puppet-neutron/commit/?id=a994da94d7ff55b4cafbb559643221a51b4e8e9e
Submitter: Jenkins
Branch: stable/juno

commit a994da94d7ff55b4cafbb559643221a51b4e8e9e
Author: Mike Dorman <email address hidden>
Date: Mon Jan 12 15:27:50 2015 -0700

    Correct docs on format for neutron::policy data

    Correct the format of the $policies parameter to neutron::policy.
    That parameter is passed directly to create_resources, so it needs
    to be in a format acceptable to that.

    Just updating docs here as anyone already using the policy classes
    are likely not using the (incorrectly) documented format, anyway.

    Change-Id: Ib69e2e421b216d6087ad47c198067667db89cc33
    Closes-bug: 1409897
    (cherry picked from commit 6d2aa10d8f8ed2dc05ee300e067e431d02d2209e)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/187398
Committed: https://git.openstack.org/cgit/stackforge/puppet-nova/commit/?id=bec17f1f9482cb1f551159319d36edf5f81164d9
Submitter: Jenkins
Branch: stable/juno

commit bec17f1f9482cb1f551159319d36edf5f81164d9
Author: Mike Dorman <email address hidden>
Date: Mon Jan 12 15:22:06 2015 -0700

    Correct docs on format for nova::policy data

    Correct the format of the $policies parameter to nova::policy.
    That parameter is passed directly to create_resources, so it needs
    to be in a format acceptable to that.

    Just updating docs here as anyone already using the policy classes
    are likely not using the (incorrectly) documented format, anyway.

    Change-Id: I774678f0b49ee05b6aee6a5565302377d8eae186
    Closes-bug: 1409897
    (cherry picked from commit 96b96f33939862543e62695b1dff14b80d893c33)