Interaction between various unit/virt/disk tests

Bug #1409173 reported by Rick Harris
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Rick Harris

Bug Description

Looks like a couple of test classes are leaking `setUp` state which are causing another test to randomly fail... this one
test_can_resize_need_fs_type_specified

I don't really know why this isn't failing in the gate; could be the fact that I'm using `nose` as a test runner and happen to be running the test_api tests after test_inject.

Anyway, the solution is to add the appropriate `tearDown` methods which restore the state of the modules to their pre-test condition.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/146234

Changed in nova:
assignee: nobody → Rick Harris (rconradharris)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/146234
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5896fb10a4804824a00127fc2b841d5a0735bccf
Submitter: Jenkins
Branch: master

commit 5896fb10a4804824a00127fc2b841d5a0735bccf
Author: Rick Harris <email address hidden>
Date: Fri Jan 9 18:29:58 2015 -0600

    virt: Fix interaction between disk API tests

    A couple of tests were leaking `setUp` state causing the
    `test_can_resize_need_fs_type_specified` test to randomly fail.

    This probably passed in the gate due to the ordering happening to be correct
    everytime. Since I'm using `nosetests`, I happen to be running the tests in
    the 'wrong' order.

    The solution is to have the tests clean up their state between runs.

    Change-Id: Ib9fe973d7784f763ad4714bd39085bc1d256d9c7
    Closes-Bug: 1409173

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.