Fix XenAPI Netinject tests for Mac

Bug #1409135 reported by Rick Harris
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Rick Harris

Bug Description

The netinject tests in XenAPI fails on a Mac.

The proximate cause is `netaddr` returning different stringification results between Mac and Linux versions.

The ultimate cause, turns out to be the underlying `socket.inet_ntop` function call which is different between the two operating systems.

An upstream bug is lodged here: https://github.com/drkjam/netaddr/issues/82

Until this is fixed, the easiest fix is to change our expectation depending on the OS in the few (possilbly one) case that it matters.

Changed in nova:
assignee: nobody → Rick Harris (rconradharris)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/146207

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/146207
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=713767660ba44421ea5e0406d121ea868ad178ac
Submitter: Jenkins
Branch: master

commit 713767660ba44421ea5e0406d121ea868ad178ac
Author: Rick Harris <email address hidden>
Date: Tue Feb 10 12:25:05 2015 -0600

    network: Fix IPv6 tests for Mac

    Some network tests would fail on a Mac because the IPv6 addressed returned
    wasn't an exact match due to a difference in the `socket.inet_ntop` function
    that `netaddr` uses.

    On a Mac 0 parts of the IPv6 are compressed away to '::' whereas on Linux they
    remain ':0:'.

    Ultimately, the fix should be in the upstream `netaddr` library which already
    has an issue logged for it: https://github.com/drkjam/netaddr/issues/82

    Until that's fixed, the solution is to skip the offending tests.

    Co-Authored-By: Johannes Erdfelt <email address hidden>
    Change-Id: I7a8a49f4105079a686e553b4d002f04a26b93d0f
    Closes-Bug: 1409135

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/156414

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (master)

Reviewed: https://review.openstack.org/156414
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1234f724bc591545df74648d306376bff256eadb
Submitter: Jenkins
Branch: master

commit 1234f724bc591545df74648d306376bff256eadb
Author: Rick Harris <email address hidden>
Date: Mon Feb 16 17:13:23 2015 -0600

    network: Fix another IPv6 test for Mac

    Commit 713767660ba44421ea5e0406d121ea868ad178ac skipped some tests on a Mac
    that would fail because OSX doesn't stringify IPv6 addresses properly.

    This test was missed, so adding it now.

    Change-Id: I413e2dae75e2144132db468f3e0c81229e3bf45a
    Related-Bug: 1409135

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/163636

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (master)

Reviewed: https://review.openstack.org/163636
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2dfa4b8c42fd1afefd5c9b24f9d9ea3c1633149d
Submitter: Jenkins
Branch: master

commit 2dfa4b8c42fd1afefd5c9b24f9d9ea3c1633149d
Author: Rick Harris <email address hidden>
Date: Wed Mar 11 17:53:08 2015 -0500

    network: Fix another IPv6 test for Mac

    Commit 713767660ba44421ea5e0406d121ea868ad178ac skipped some tests on a Mac
    that would fail because OSX doesn't stringify IPv6 addresses properly.

    This test was missed, so adding it now.

    Change-Id: Ic173b68f2c8cbdd621456a79b242e9be11f2c30f
    Related-Bug: 1409135

Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.