stack-adopt will delete the resource when rollback

Bug #1408904 reported by huangtianhua
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
huangtianhua
Juno
Fix Released
Medium
huangtianhua

Bug Description

1. heat stack-adopt -a adopt_file.yaml ADT -r
2. something wrong in adopt, so enter the rollback, the resources are all be deleted.
3. I think it's a bug, rollback can delete the stack but the resources shouldn't be delete due just to adopt the resources not to create.

Changed in heat:
assignee: nobody → huangtianhua (huangtianhua)
Revision history for this message
Steven Hardy (shardy) wrote :

Yeah, we should probably enter the same flow as abandon and just delete the stack.

Changed in heat:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/151594

Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/151594
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=4af2892fbbf730827c1237ab169e681bab506515
Submitter: Jenkins
Branch: master

commit 4af2892fbbf730827c1237ab169e681bab506515
Author: huangtianhua <email address hidden>
Date: Fri Jan 30 18:25:02 2015 +0800

    Just to delete the stack when adopt rollback

    If stack adopt failed and need to rollback, we just
    enter the abandon flow only to delete the stack.

    Change-Id: Ia7f9915fa40e8e836a41c0b9cc9b8051ae2e0d23
    Closes-Bug: #1408904

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/161146

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/juno)

Reviewed: https://review.openstack.org/161146
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=9f02b3aaaf4543b819da428d327d0ad8db07fd0c
Submitter: Jenkins
Branch: stable/juno

commit 9f02b3aaaf4543b819da428d327d0ad8db07fd0c
Author: huangtianhua <email address hidden>
Date: Fri Jan 30 18:25:02 2015 +0800

    Just to delete the stack when adopt rollback

    If stack adopt failed and need to rollback, we just
    enter the abandon flow only to delete the stack.

    Change-Id: Ia7f9915fa40e8e836a41c0b9cc9b8051ae2e0d23
    Closes-Bug: #1408904
    (cherry picked from commit 4af2892fbbf730827c1237ab169e681bab506515)

tags: added: in-stable-juno
Thierry Carrez (ttx)
Changed in heat:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.